Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removal of polyfil packages #2305

Closed
thompson-tomo opened this issue Mar 3, 2024 · 4 comments · Fixed by #2308
Closed

Removal of polyfil packages #2305

thompson-tomo opened this issue Mar 3, 2024 · 4 comments · Fixed by #2308
Labels
agent-dotnet community enhancement New feature or request

Comments

@thompson-tomo
Copy link
Contributor

thompson-tomo commented Mar 3, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.
I want that the packages which i am adding to my projects only has dependencies on those packages which it needs & can not obtain via Framework.

Describe the solution you'd like
I would like that for the net 6 TFM polyfil packages such as those listed below are not included so that dependencies are kept to a minimum in the case of Elastic.APM the dependencies will be reduced by 80%.

  • System.Diagnostics.DiagnosticSource
  • System.Reflection.Metadata
  • System.Threading.Tasks.Dataflow
  • System.Threading.Tasks.Extensions

Describe alternatives you've considered
Accept that the polyfil packages are included

Additional context
Continuation of #2266
@thompson-tomo thompson-tomo added the enhancement New feature or request label Mar 3, 2024
@thompson-tomo
Copy link
Contributor Author

Note happy to submit a PR for the changes

@stevejgordon
Copy link
Contributor

@thompson-tomo This sounds reasonable, and we'd very much welcome a PR for this.

@thompson-tomo
Copy link
Contributor Author

thompson-tomo commented Mar 4, 2024 •
edited
Loading

Great I will aim to do PR in the next week or so and submit it like: elastic/ecs-dotnet#357

@thompson-tomo thompson-tomo mentioned this issue Mar 5, 2024
Closed
thompson-tomo added a commit to thompson-tomo/apm-agent-dotnet that referenced this issue Mar 10, 2024
@thompson-tomo
elastic#2305 Remove polyfill packages
b360d7d
@thompson-tomo thompson-tomo mentioned this issue Mar 10, 2024
Merged
@thompson-tomo
Copy link
Contributor Author

@stevejgordon pr is all done with the tweaked conditions to reduce dependencies.

thompson-tomo added a commit to thompson-tomo/apm-agent-dotnet that referenced this issue Mar 29, 2024
@thompson-tomo
elastic#2305 Remove polyfill packages
b117e82
thompson-tomo added a commit to thompson-tomo/apm-agent-dotnet that referenced this issue Apr 21, 2024
@thompson-tomo
elastic#2305 Remove polyfill packages
efb81fd
thompson-tomo added a commit to thompson-tomo/apm-agent-dotnet that referenced this issue May 1, 2024
@thompson-tomo
elastic#2305 Remove polyfill packages
e7dc387
thompson-tomo added a commit to thompson-tomo/apm-agent-dotnet that referenced this issue May 6, 2024
@thompson-tomo
elastic#2305 Remove polyfill packages
d54dbfb
thompson-tomo added a commit to thompson-tomo/apm-agent-dotnet that referenced this issue May 8, 2024
@thompson-tomo
elastic#2305 Remove polyfill packages
e59b174
Mpdreamz added a commit that referenced this issue May 23, 2024
@thompson-tomo @Mpdreamz
#2305 Remove polyfill packages (#2308)
54a7105 
Co-authored-by: Martijn Laarman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
agent-dotnet community enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#2305 Remove polyfill packages thompson-tomo/apm-agent-dotnet
2 participants
@stevejgordon @thompson-tomo