Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Profiler auto-instrumentation on .NET Framework 4.7.2+ doesn't honour the VerifyServerCert configuration #2530

Open
stevejgordon opened this issue Dec 12, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@stevejgordon
Copy link
Contributor

Our agent targets different versions of .NET, and specific code paths apply to each target for certain functionality. One of these is the handling for ELASTIC_APM_VERIFY_SERVER_CERT, which behaves differently on older .NET Framework versions (< 4.6.2) due to limitations there.

Our profiler zip asset only ships the base net462 libraries. Therefore, when using auto-instrumentation with the profiler, some features, including the verify server certificate configuration option, are not applied, even when the instrumented application runs on .NET 4.7.2 or newer.

We need to update the build scripts and release workflows to ensure that the net472 libraries are included in the zip file and resolved by the managed loader.

@stevejgordon stevejgordon added the bug Something isn't working label Dec 12, 2024
@stevejgordon
Copy link
Contributor Author

Alternatively, we could investigate making this code path a runtime check rather than a compile-time feature requiring a specific target.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant