Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Framework name and version in Sanic instrumentation #2175

Closed
goodki-d opened this issue Dec 11, 2024 · 2 comments
Closed

Add Framework name and version in Sanic instrumentation #2175

goodki-d opened this issue Dec 11, 2024 · 2 comments
Labels
agent-python community Issues opened by the community triage Issues awaiting triage

Comments

@goodki-d
Copy link

Django and Flask integrations have framework name and version extracted from the packages automatically.
This is missing in Sanic integration, it will be very useful as I have a lot of applications running different frameworks and versions.

(I currently use manual config which is not scalable and hard to maintain on upgrade)

@github-actions github-actions bot added agent-python community Issues opened by the community triage Issues awaiting triage labels Dec 11, 2024
@xrmx xrmx changed the title Add Framework name and version in Sanic integration Add Framework name and version in Sanic instrumentation Dec 19, 2024
@xrmx
Copy link
Member

xrmx commented Dec 24, 2024

@goodki-d Are you passing a client explicitly when instantiating ElasticAPM? If so you need to use elasticapm.contrib.sanic.utils.make_client that will set framework name and version. The one created by default should contain the framework data already.

@goodki-d
Copy link
Author

Yes I've been creating client object and passing it manually to sanic.ElasticAPM.
Thanks! I couldn't find anything related in docs so I thought the feature was absent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-python community Issues opened by the community triage Issues awaiting triage
Projects
None yet
Development

No branches or pull requests

2 participants