Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] [aws] [s3] Introduce ignore_older & start_timestamp for s3 input #41804

Conversation

Kavindu-Dodan
Copy link
Contributor

Proposed commit message

Follow-up for start_timestamp , hence in draft till complete

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

Todo - fill up

Related issues

Fixes ##39116

Use cases

Todo - fill up

@Kavindu-Dodan Kavindu-Dodan added the backport-8.x Automated backport to the 8.x branch with mergify label Nov 26, 2024
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 26, 2024
@Kavindu-Dodan Kavindu-Dodan force-pushed the feat/s3-input-start-time-and-ignore-old branch from 02af061 to 4c0c115 Compare November 26, 2024 23:16
@elastic elastic deleted a comment from botelastic bot Nov 27, 2024
Copy link
Contributor

mergify bot commented Nov 27, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b feat/s3-input-start-time-and-ignore-old upstream/feat/s3-input-start-time-and-ignore-old
git merge upstream/main
git push upstream feat/s3-input-start-time-and-ignore-old

Signed-off-by: Kavindu Dodanduwa <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
@Kavindu-Dodan Kavindu-Dodan force-pushed the feat/s3-input-start-time-and-ignore-old branch from 7a5a96f to 360947f Compare November 27, 2024 18:43
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
@Kavindu-Dodan Kavindu-Dodan force-pushed the feat/s3-input-start-time-and-ignore-old branch 2 times, most recently from ae06c0a to d6a40a4 Compare November 27, 2024 19:11
@Kavindu-Dodan Kavindu-Dodan force-pushed the feat/s3-input-start-time-and-ignore-old branch from d6a40a4 to 8ac9010 Compare November 27, 2024 19:24
@Kavindu-Dodan
Copy link
Contributor Author

Closing and reopening freshly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant