Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we migrated serverless docs to AsciiDoc, we had to add SVGs for icons that were previously handled by the
DocIcon
component. To allow us to move more quickly, I added the SVGs to each content repo, but planned to centralize those icons in this repo later (i.e. now 😄).The approach I used in this PR would mean the new way to include icons in AsciiDoc files would be to use a shared attribute following the pattern
icon-{type}
wheretype
in the string that was used inDocIcon
(and is listed in EUI icon docs).For example:
For the reviewer — here's specifically what this PR does:
icon-{type}
.icon-{type}
.After this is merged, I can open a PR in /docs-content, /security-docs, and /observability-docs to remove the local SVGs and update the syntax to use the new shared attributes.