Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bullet] Reorder the tooltip info #2360

Open
markov00 opened this issue Mar 14, 2024 · 4 comments
Open

[Bullet] Reorder the tooltip info #2360

markov00 opened this issue Mar 14, 2024 · 4 comments
Labels
:bullet Bullet chart related issues enhancement New feature or request

Comments

@markov00
Copy link
Member

The tooltip currently shows the Active,Value and Target labels in this order.
I'd like to suggest to change the order to have the most important information first and the other later:
Value,Target,Active or Value,Active,Target

Screenshot 2024-03-14 at 18 11 45

Moving the Value as the first information on the tooltip makes it a bit more prominent, and gives less of the impression that the Active value is the current important value on the chart.

If possible, I'd also like to suggest to fade out a bit the style of the Active element, or make the Value more prominent (bold?)

Also the naming could be reviewed for the active Active -> Current.

cc @gvnmagni

@markov00 markov00 added enhancement New feature or request needs design A design pass is required and not available :bullet Bullet chart related issues labels Mar 14, 2024
@gvnmagni
Copy link

I think it is ok to re-organise the elements and I agree that Active, as a word, might need to be evaluated in favour of Current or something similar.

Visually speaking, I am proposing two slightly different options with a lighter and bolder role for the Value numbers. Which one do you think would work better?

Frame 155

@markov00
Copy link
Member Author

markov00 commented Mar 20, 2024

@nickofthyme WDYT?
I like both, definitely the more prominent one is probably a good choice (and resemble the current cartesian header style)

@nickofthyme
Copy link
Collaborator

Looks good to me, only thing I would be hesitant on is if we were to add a title in the future, in which case the value separation may look strange.

image

@markov00
Copy link
Member Author

@nickofthyme I've chatted with @gvnmagni and your solution is fine for us, let's go with that.
The terms value and current are hardcoded and localized, where instead target can be customized in lens appearance panel.

@gvnmagni gvnmagni removed the needs design A design pass is required and not available label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:bullet Bullet chart related issues enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants