fix(metric): chart not rendered when the trend is empty #2447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexwizp
changed the title
markov00
requested changes
May 30, 2024
There was a problem hiding this comment.
This doesn't solve the issue completely.
The root cause is a couple of lines below that changed line where:
const [xMin, xMax] = [sortedTrendData.at(0)!.x, sortedTrendData.at(-1)!.x];
We need to avoid these type of assertions because they can cause all sort of issues around them (cc @dej611)
Even if with a single element the chart renders, the SVG is malformed (will contain NaN numbers that throws in the console).
The correct fix should check if the trend contains at least 2 elements. If not you should assure a correct background/foreground color selection (changing it to if(trend.length < 2) return null doesn't solves it quickly unfortunately)
packages/charts/src/chart_types/metric/renderer/dom/sparkline.tsx
Outdated
Show resolved
Hide resolved
nickofthyme
reviewed
May 31, 2024
|
buildkite update screenshots |
markov00
requested changes
May 31, 2024
nickofthyme
approved these changes
May 31, 2024
markov00
approved these changes
Jun 3, 2024
markov00
changed the title
nickofthyme
pushed a commit
that referenced
this pull request
Jun 4, 2024
# [65.2.0](v65.1.0...v65.2.0) (2024-06-04) ### Bug Fixes * **deps:** update dependency @elastic/eui to ^94.5.2 ([#2450](#2450)) ([26b425c](26b425c)) * **deps:** update dependency @elastic/eui to ^94.6.0 ([#2454](#2454)) ([6759469](6759469)) * **deps:** update dependency @playwright/test to ^1.44.1 ([#2451](#2451)) ([158b4c2](158b4c2)) * **deps:** update dependency json-schema-to-typescript to v14.0.5 ([#2452](#2452)) ([7947e17](7947e17)) * **metric:** chart not rendered when the trend is empty ([#2447](#2447)) ([6042cc8](6042cc8)) * **sunburst:** rendering for full sections ([#2457](#2457)) ([58c2721](58c2721)) ### Features * **legend:** improve tooltip wording ([#2439](#2439)) ([27c04f4](27c04f4))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2445
Summary
This change ensures that the chart component can handle
emptytrend data appropriately, preventing rendering failures and console errors.Screen
Screen:
Trend was set to []No
consoleissues