fix: add option to disable the isolated point styles on line and area charts #2472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickofthyme
added
:styling
|
buildkite update screenshots |
nickofthyme
changed the title
nickofthyme
pushed a commit
that referenced
this pull request
Jun 24, 2024
## [66.0.4](v66.0.3...v66.0.4) (2024-06-24) ### Bug Fixes * **deps:** update dependency @elastic/eui to v95 ([#2462](#2462)) ([040c354](040c354)) * option to disable the isolated point styles on line and area charts ([#2472](#2472)) ([ae16815](ae16815)) * outside rect annotation placement and group relations ([#2471](#2471)) ([d46fb41](d46fb41))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR add the
enabledprop to theisolatedPointstyle option in theThemeforLineSeriesandAreaSeries. These isolated styles can be unexpected and unwanted and in such case difficult to remove. Thus setting thisenabledoption tofalsewill render the points as normal points.Details
Based on discussions from #2460, I think it's best to have an easy way to disable the isolated point styles.
Issues
related to #2460
Checklist
:xy,:partition):interactions,:axis)closes #123,fixes #123)packages/charts/src/index.ts