Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pipe syntax to declare optional fields #1937

Merged

Conversation

miguelgrinberg
Copy link
Collaborator

Fixes #1928

Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@miguelgrinberg miguelgrinberg added the backport 8.x Backport to 8.x label Nov 6, 2024
@miguelgrinberg miguelgrinberg merged commit 5511abe into elastic:main Nov 6, 2024
17 of 18 checks passed
@miguelgrinberg miguelgrinberg deleted the optional-with-pipe-syntax branch November 6, 2024 18:40
github-actions bot pushed a commit that referenced this pull request Nov 6, 2024
* Support pipe syntax to declare optional fields

Fixes #1928

* type ignores for pipe syntax in 3.8/3.9

(cherry picked from commit 5511abe)
@pySilver
Copy link

pySilver commented Nov 7, 2024

Thanks!

miguelgrinberg added a commit that referenced this pull request Nov 7, 2024
* Support pipe syntax to declare optional fields

Fixes #1928

* type ignores for pipe syntax in 3.8/3.9

(cherry picked from commit 5511abe)

Co-authored-by: Miguel Grinberg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 8.x Backport to 8.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Type hints are not working correctly when using python 3.12
3 participants