Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiDataGrid] Fix scrollbar bouncing issue in v95.12.0 #8041

Merged
merged 2 commits into from
Sep 25, 2024
Merged

[EuiDataGrid] Fix scrollbar bouncing issue in v95.12.0 #8041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d7b6ff
Fix Chrome dimensions bug, which, for some reason, is caused by CSS??
cee-chen Sep 25, 2024
50a0b71
changelog
cee-chen Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified ...ence/chrome_desktop_Tabular_Content_EuiDataGrid_rowHeightsOptions_prop_Auto.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...rence/chrome_mobile_Tabular_Content_EuiDataGrid_rowHeightsOptions_prop_Auto.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions packages/eui/changelogs/upcoming/8041.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
**Bug fixes**

- Fixed an `EuiDataGrid` rendering bug that was causing bouncing scrollbar issues
4 changes: 4 additions & 0 deletions packages/eui/src/components/datagrid/body/cell/data_grid_cell.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,10 @@ export const euiDataGridRowCellStyles = (euiThemeContext: UseEuiTheme) => {
// Control columns should be vertically centered with the *first line* of text
// for both single and multi-line heights (see https://github.com/elastic/eui/issues/7897)
controlColumn: css`
${
// ❗ For some reason Chromium browsers will scrollbar stutter without this :|||
logicalCSS('max-height', '100%')
}
display: inline-flex;
align-items: start;
gap: ${euiTheme.size.xxs}; /* EuiButtonIcons */
Expand Down
Loading