Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[High Contrast Mode] Form controls #8193

Merged
merged 11 commits into from
Dec 2, 2024
Merged

[High Contrast Mode] Form controls #8193

merged 11 commits into from
Dec 2, 2024

Commits on Nov 27, 2024

  1. [EuiForm] Increase contrast of form control inputs across the board 

    + add borders to prepend/append labels - contrast feels low otherwise, especially for disabled inputs
    @cee-chen
    cee-chen committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    a1a95a8 View commit details
    Browse the repository at this point in the history

  2. [EuiCheckbox][EuiRadio] Increase selection control border contrast 

    - always set a border (even if transparent) for Windows high contrast themes
    @cee-chen
    cee-chen committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    d6ad4bd View commit details
    Browse the repository at this point in the history

  3. [EuiRadio] Fix Windows high contrast rendering 

    - have to use `empty` instead of `dot` as Windows will always render the `dot`

+ VRT
    @cee-chen
    cee-chen committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    51af990 View commit details
    Browse the repository at this point in the history

  4. [EuiSwitch] Increase contrast for disabled modes and compressed modes 

    - compressed modes in particular require a windows forced contrast mode override - since they have no icon, users have literally no way of telling what on/off state is without it
    @cee-chen
    cee-chen committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    8c5ce8c View commit details
    Browse the repository at this point in the history

  5. [EuiFilePicker] Fix border color

    @cee-chen
    cee-chen committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    363fed7 View commit details
    Browse the repository at this point in the history

  6. [EuiComboBox] Fix list dividers to match EuiSelectable

    @cee-chen
    cee-chen committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    4c93618 View commit details
    Browse the repository at this point in the history

  7. [EuiForm] Generally improve contrast on underline gradient 

    - increase size in all high contrast modes

- use inline SVG workaround (sadly necessarily) for Windows high contrast mode

- remove form background tint on all high contrast modes for better consistency

+ add VRT screenshots for focus state, dark mode
    @cee-chen
    cee-chen committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    3086ef9 View commit details
    Browse the repository at this point in the history

  8. [EuiForm] Increase clear button contrast + fix display on Windows

    @cee-chen
    cee-chen committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    0580f23 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2024

  1. [EuiToast] Increase color indicator to match form underline + add for… 

    …ced colors workaround
    @cee-chen
    cee-chen committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    75f034a View commit details
    Browse the repository at this point in the history

  2. [PR feedback] Fix readOnly focus state

    @cee-chen
    cee-chen committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    036e2a9 View commit details
    Browse the repository at this point in the history

  3. [PR feedback] Form clear button - respect windows theme colors more

    @cee-chen
    cee-chen committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    8912c05 View commit details
    Browse the repository at this point in the history