Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[High Contrast Mode] Ranges, color pickers, and date pickers #8199

Merged
merged 18 commits into from
Dec 5, 2024

Commits on Dec 3, 2024

  1. Configuration menu
    Copy the full SHA
    33b1981 View commit details
    Browse the repository at this point in the history
  2. [Eui(Dual)Range] Misc syntax cleanup

    - pass full theme context (matching all our other helpers) instead of just `euiTheme`
    
    - use `is` type predicate instead of `as` cast
    
    - use getters to repeat vars instead of comments (which updates the thumb bg color to match in high contrast mode)
    cee-chen committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    aaa0095 View commit details
    Browse the repository at this point in the history
  3. [Eui(Dual)Range] Set up CSS variable for dynamic thumb colors

    - on focus, can be either the focus color or the level color
    
    - we'll be using this var shortly for higher contrast borders
    cee-chen committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    6d02877 View commit details
    Browse the repository at this point in the history
  4. [Eui(Dual)Range] Improve the visibility of thumbs in high contrast mode

    + make the outlines of focused thumbs inherit from the level (more polished) in non-high contrast mode as well
    cee-chen committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    bca189a View commit details
    Browse the repository at this point in the history
  5. [Eui(Dual)Range] Increase contrast of ticks + fix Win high contrast t…

    …hemes
    
    + tech debt - fix `any` typing
    cee-chen committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    ab074ed View commit details
    Browse the repository at this point in the history
  6. [Eui(Dual)Range] Fix tooltips in high contrast Windows + increase dar…

    …k mode visibility
    
    + tech debt - dogfood new arrow styles helper. this adds another mildly repetitive/annoying Emotion className, but that tradeoff is probably worth it
    
    + other misc CSS cleanup/simplifications
    
    - minute Loki diffs appear to be coming from aliasing from the transparent border, but shouldn't be a meaningful change
    cee-chen committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    4d9497e View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    1747af4 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    8f853e7 View commit details
    Browse the repository at this point in the history
  9. [EuiColorPicker] Add border + fix hue/saturation pickers in Win high …

    …contrast themes
    
    + add VRT
    cee-chen committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    9538ee5 View commit details
    Browse the repository at this point in the history
  10. [EuiColorPicker] Fix unnecessary CSS workaround

    - by using `aspect-ratio` instead of padding-bottom hack
    cee-chen committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    7856503 View commit details
    Browse the repository at this point in the history
  11. [EuiColorPicker] (opinionated) Increase visible thumb contrast further

    - remove transparent background - it's more important that the thumb be visible
    
    - remove box shadows and make borders/outlines extra thick
    
    + always show outlines, on mouse focus, not just keyboard focus
    
    - open to feedback - dark mode feels better *while* focused, but not necessarily while not focused
    cee-chen committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    2c89304 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    859eb61 View commit details
    Browse the repository at this point in the history
  13. [react-datepicker] Fix Windows high contrast/forced color modes rende…

    …ring calendar selections invisible
    cee-chen committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    c016bc5 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    d225ace View commit details
    Browse the repository at this point in the history
  15. [EuiSuperDatePicker] Fix duplicate high contrast borders

    + DRY out `euiFormControlDefaultShadow` usage/unsets with newer API
    cee-chen committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    1011d27 View commit details
    Browse the repository at this point in the history
  16. [EuiSuperDatePicker] Improve Windows high contrast state indication

    - needs updating still isn't great, but I think this is the best I can do for now :/
    cee-chen committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    543f22b View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    9331f5a View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2024

  1. Configuration menu
    Copy the full SHA
    c7e35b0 View commit details
    Browse the repository at this point in the history