Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Key flyout UX behavior - Keyboard navigation broken #168164

Closed
SiddharthMantri opened this issue Oct 5, 2023 · 6 comments · Fixed by elastic/eui#7259
Closed

API Key flyout UX behavior - Keyboard navigation broken #168164

SiddharthMantri opened this issue Oct 5, 2023 · 6 comments · Fixed by elastic/eui#7259
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Users/Roles/API Keys Project:Accessibility Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!

Comments

@SiddharthMantri
Copy link
Contributor

SiddharthMantri commented Oct 5, 2023

Kibana version: 8.x

Describe the bug:
Tabbing order: when the flyout appears, the name field is in focus, but tabbing only cycles between the name field and the close button. If another control is activated, e.g. the Include metadata toggle, the tab stops will include the remainder of the flyout controls, however tabbing will then escape the flyout and cycle through the Kibana header and top navigation elements before getting stuck back in the name/close tab loop of the flyout.

Additionally, we should add screen reader attributes for the Code editors to say more than just "Code Editor"

Expected behavior: Tabbing should cycle through relevant elements within the flyout and should not escape the flyout. The user should have to close the flyout in order to tab through elements on the main screen.

Screenshots (if relevant):

Screen.Recording.2023-09-27.at.19.00.19.mov
@SiddharthMantri SiddharthMantri added bug Fixes for quality problems that affect the customer experience Project:Accessibility Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! Feature:Users/Roles/API Keys labels Oct 5, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@cee-chen
Copy link
Member

cee-chen commented Oct 6, 2023

Shoot sorry, I accidentally used a magic keyword that I should not have in my EUI PR. This won't be resolved in Kibana until the next EUI upgrade

@cee-chen cee-chen reopened this Oct 6, 2023
@legrego
Copy link
Member

legrego commented Oct 12, 2023

Resolved via #168396

@legrego legrego closed this as completed Oct 12, 2023
@legrego
Copy link
Member

legrego commented Oct 12, 2023

Actually -- @SiddharthMantri, would you mind pulling down the latest main, and verify that #168396 fixes this behavior?

@legrego legrego reopened this Oct 12, 2023
@legrego
Copy link
Member

legrego commented Oct 17, 2023

Sid verified - looks good!

@legrego legrego closed this as completed Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Users/Roles/API Keys Project:Accessibility Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants