Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Improve chart visual defaults when there are missing time intervals #186076

Closed
1 of 3 tasks
teresaalvarezsoler opened this issue Jun 12, 2024 · 1 comment · Fixed by #196184
Closed
1 of 3 tasks
Assignees
Labels
Feature:Lens impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:large Large Level of Effort Team:DataVis Team label for DataVis Team

Comments

@teresaalvarezsoler
Copy link

teresaalvarezsoler commented Jun 12, 2024

Problem
When there are missing time buckets in a time series chart, we show the isolated data points as empty circles. However, this way of displaying the data is very hard to read and often confusing.
Image

Solution
The solution is described in detail here. In summary:

  • Remove empty circles and introduce value dots when data density is low enough
  • Fill the gaps between intervals with a line by default

Image

Communicating the change to users
We should add a tour that communicates the change to users and let them know how to change the behaviour if they want to. The tour will appear when a user creates a new line chart (regardless of whether it has missing time buckets?).

(exact wording TBD)
Image

Existing charts
We would like to keep existing charts as untouched as possible, but we don't want to introduce two chart styles while we know the current behaviour is not readable and confusing. Therefore, we decided to:

  • Remove empty circles for all charts and introduce value dots when data density is low enough
  • Fill the gaps between intervals only if users didn't change the default configuration, otherwise, keep whatever configuration the user is using.

For the charts that change, we will show a tour letting users know about the change and how they can revert it back. The tour will be shown per user the first time they view a chart that changed which can happen either in one of these two places: 1) at the dashboard level (if there are multiple charts, only for the first chart) or 2) in the Lens editor

(exact wording TBD)

Image

Project tasks:

@gvnmagni gvnmagni self-assigned this Jul 1, 2024
@mbondyra mbondyra removed their assignment Jul 2, 2024
@teresaalvarezsoler teresaalvarezsoler added loe:large Large Level of Effort impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. and removed triage_needed labels Jul 10, 2024
@teresaalvarezsoler teresaalvarezsoler added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. and removed impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. labels Aug 30, 2024
@markov00 markov00 self-assigned this Sep 12, 2024
@markov00
Copy link
Member

As decided with @teresaalvarezsoler, we are removing from the scope of this change the tour. We always had changes in defaults in the past, it important to specify them in the release note but for now we don't need a tour to highlight that change.

markov00 added a commit that referenced this issue Oct 21, 2024
## Summary

Every line charts are now interpolated by default with a linear
interpolation.

Solves the second task of
[#186076](#186076)

fix [#186076](#186076)

before:
<img width="816" alt="Screenshot 2024-10-17 at 16 25 47"
src="https://github.com/user-attachments/assets/3b14c80b-deef-4d8d-9d5b-e118619e31cb">


after:
<img width="814" alt="Screenshot 2024-10-17 at 16 25 56"
src="https://github.com/user-attachments/assets/45788530-aeb6-4851-ac1e-c53efcd73068">

## Release note
Newly and default configured Lens line charts are now interpolated by
default with a straight Linear interpolation.

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Marta Bondyra <[email protected]>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 21, 2024
## Summary

Every line charts are now interpolated by default with a linear
interpolation.

Solves the second task of
[elastic#186076](elastic#186076)

fix [elastic#186076](elastic#186076)

before:
<img width="816" alt="Screenshot 2024-10-17 at 16 25 47"
src="https://github.com/user-attachments/assets/3b14c80b-deef-4d8d-9d5b-e118619e31cb">

after:
<img width="814" alt="Screenshot 2024-10-17 at 16 25 56"
src="https://github.com/user-attachments/assets/45788530-aeb6-4851-ac1e-c53efcd73068">

## Release note
Newly and default configured Lens line charts are now interpolated by
default with a straight Linear interpolation.

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Marta Bondyra <[email protected]>
(cherry picked from commit 5fe8aad)
kibanamachine added a commit that referenced this issue Oct 21, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Lens] fit line charts by default
(#196184)](#196184)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Marco
Vettorello","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-21T13:05:02Z","message":"[Lens]
fit line charts by default (#196184)\n\n## Summary\r\n\r\nEvery line
charts are now interpolated by default with a
linear\r\ninterpolation.\r\n\r\nSolves the second task
of\r\n[#186076](https://github.com/elastic/kibana/issues/186076)\r\n\r\nfix
[#186076](https://github.com/elastic/kibana/issues/186076)\r\n\r\nbefore:\r\n<img
width=\"816\" alt=\"Screenshot 2024-10-17 at 16 25
47\"\r\nsrc=\"https://github.com/user-attachments/assets/3b14c80b-deef-4d8d-9d5b-e118619e31cb\">\r\n\r\n\r\nafter:\r\n<img
width=\"814\" alt=\"Screenshot 2024-10-17 at 16 25
56\"\r\nsrc=\"https://github.com/user-attachments/assets/45788530-aeb6-4851-ac1e-c53efcd73068\">\r\n\r\n##
Release note\r\nNewly and default configured Lens line charts are now
interpolated by\r\ndefault with a straight Linear
interpolation.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>\r\nCo-authored-by:
Marta Bondyra
<[email protected]>","sha":"5fe8aad89d59726060ba860d2f0692ddb3ca5ffa","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","enhancement","Feature:Lens","v9.0.0","apm:review","backport:version","v8.17.0"],"title":"[Lens]
fit line charts by
default","number":196184,"url":"https://github.com/elastic/kibana/pull/196184","mergeCommit":{"message":"[Lens]
fit line charts by default (#196184)\n\n## Summary\r\n\r\nEvery line
charts are now interpolated by default with a
linear\r\ninterpolation.\r\n\r\nSolves the second task
of\r\n[#186076](https://github.com/elastic/kibana/issues/186076)\r\n\r\nfix
[#186076](https://github.com/elastic/kibana/issues/186076)\r\n\r\nbefore:\r\n<img
width=\"816\" alt=\"Screenshot 2024-10-17 at 16 25
47\"\r\nsrc=\"https://github.com/user-attachments/assets/3b14c80b-deef-4d8d-9d5b-e118619e31cb\">\r\n\r\n\r\nafter:\r\n<img
width=\"814\" alt=\"Screenshot 2024-10-17 at 16 25
56\"\r\nsrc=\"https://github.com/user-attachments/assets/45788530-aeb6-4851-ac1e-c53efcd73068\">\r\n\r\n##
Release note\r\nNewly and default configured Lens line charts are now
interpolated by\r\ndefault with a straight Linear
interpolation.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>\r\nCo-authored-by:
Marta Bondyra
<[email protected]>","sha":"5fe8aad89d59726060ba860d2f0692ddb3ca5ffa"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196184","number":196184,"mergeCommit":{"message":"[Lens]
fit line charts by default (#196184)\n\n## Summary\r\n\r\nEvery line
charts are now interpolated by default with a
linear\r\ninterpolation.\r\n\r\nSolves the second task
of\r\n[#186076](https://github.com/elastic/kibana/issues/186076)\r\n\r\nfix
[#186076](https://github.com/elastic/kibana/issues/186076)\r\n\r\nbefore:\r\n<img
width=\"816\" alt=\"Screenshot 2024-10-17 at 16 25
47\"\r\nsrc=\"https://github.com/user-attachments/assets/3b14c80b-deef-4d8d-9d5b-e118619e31cb\">\r\n\r\n\r\nafter:\r\n<img
width=\"814\" alt=\"Screenshot 2024-10-17 at 16 25
56\"\r\nsrc=\"https://github.com/user-attachments/assets/45788530-aeb6-4851-ac1e-c53efcd73068\">\r\n\r\n##
Release note\r\nNewly and default configured Lens line charts are now
interpolated by\r\ndefault with a straight Linear
interpolation.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>\r\nCo-authored-by:
Marta Bondyra
<[email protected]>","sha":"5fe8aad89d59726060ba860d2f0692ddb3ca5ffa"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Marco Vettorello <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Lens impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:large Large Level of Effort Team:DataVis Team label for DataVis Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants