Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "Add a Filter" Dropdown in 7.0 prevents users from seeing fieldnames #36409

Closed
maggieghamry opened this issue May 9, 2019 · 13 comments · Fixed by #85320
Closed

The "Add a Filter" Dropdown in 7.0 prevents users from seeing fieldnames #36409

maggieghamry opened this issue May 9, 2019 · 13 comments · Fixed by #85320
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Feature:Filters Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.

Comments

@maggieghamry
Copy link
Contributor

Kibana version: 7.0

Elasticsearch version: 7.0

Describe the bug: In the Kibana UI (6.7 and prior), when you go to the Discover pane, and add a filter, the UI dynamically expands to fit the field names. For some reason, in 7.0, the dropdown has been adjusted to a fixed size with no way to expand. This makes it impossible to see the full names for fields with longer names.

Steps to reproduce:

  1. Login to Kibana
  2. Click "Discover"
  3. Click "Add a filter"

Expected behavior:

Allow field name visibility

**Screenshots **

Kibana 7.0:
image

Kibana 6.7 and prior:
image

@maggieghamry maggieghamry added bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Feature:Filters Feature:Discover Discover Application labels May 9, 2019
@timroes
Copy link
Contributor

timroes commented May 14, 2019

@cchaos do you have any recommendations what we could do here, or any specific EUI tweak we're missing?

@cchaos
Copy link
Contributor

cchaos commented May 29, 2019

We could possibly increase the width of the popover itself, giving more room for the field select. But currently the EuiComboBox's dropdown will only ever be as wide as its input.

@nreese nreese added Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jun 12, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-design

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@cjcenizal
Copy link
Contributor

We could possibly increase the width of the popover itself, giving more room for the field select.

We could also place the "Field" combo box on its own row, instead of making it share space with the "Operator" field.

I created elastic/eui#2082 to track the EUI enhancement that would solve this problem at the combo box level.

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@wolph
Copy link

wolph commented Jun 4, 2020

Since this still hasn't been resolved, I suggest installing stylus and adding a bit of CSS. I'm currently using these to make everything a bit more usable for large (tested on 4k) monitors:

/* ==UserStyle==
@name           kibana fixes
@namespace      github.com/openstyles/stylus
@version        1.0.0
@description    Kibana design issues
@author         Me
==/UserStyle== */
@-moz-document url-prefix("https://kibana.") {
    .kbnDocViewer__actionButton {
        opacity: 0.2;
    }
    table.table-condensed > tbody > tr {
        border-bottom: 1px solid #eee;
    }
    div.kuiLocalBreadcrumbs,
    div.kbnTopNav__row {
        position: fixed;
        background: #fff;
        top: 0px;
        height: 50px;
        z-index: 1000;
        border-bottom: 1px solid #ccc;
    }
    div.kuiLocalBreadcrumbs {
        left: 40%;
        width: 10%;
    }
    div.kbnTopNav__row {
        left: 50%;
        width: 50%;
    }
    header-global-nav.header-global-wrapper {
        width: 40%;
    }
    .sidebar-container .sidebar-list .sidebar-item-title {
        height: 20px;
    }
    .dscWrapper {
        padding-left: 2px;
    }

    div.euiPopover__panel, div.euiContextMenu {
        width: calc(100vw - 200px) !important;
    }

    div.globalFilterItem__editorForm div.euiFlexGroup {
        max-width: 60%;
    }
    
    div.globalFilterItem__editorForm div.euiFlexGroup > div.euiFlexItem,
    div.globalFilterItem__editorForm div.euiFormRow,
    div.globalFilterItem__editorForm div.euiFormControlLayout,
    div.euiPopover__panel div.euiFlexItem > div,
    div.globalFilterItem__editorForm div.euiComboBox,
    div.euiComboBox__inputWrap{
        max-width: 100% !important;
        width: 100% !important;
    }
    
    div.ReactVirtualized__List,div.ReactVirtualized__Grid__innerScrollContainer, div.euiComboBoxOptionsList__rowWrap{
        width: 800px !important;
        max-width: 800px !important;
    }
    
    div.euiComboBoxOptionsList {
        width: 40% !important;
        max-width: 40% !important;
    }
    
    div.euiForm > div > div:nth-child(3) {
        float: left;
        clear: both;
        top: 60px;
        left: 65%;
        width: 30%;
        position: absolute;
    }
}

image

@lizozom
Copy link
Contributor

lizozom commented Jul 5, 2020

This issue will effect any consumer of TopNav (and not only dashboard and discover).

@elastic/kibana-design any plans to support this option in the drop down component?
I think the level of impact on users here is significant.

@cchaos
Copy link
Contributor

cchaos commented Jul 6, 2020

@lizozom Can you create an issue in the EUI repo for what is needed by what component to support this?

@lizozom
Copy link
Contributor

lizozom commented Jul 15, 2020

@cchaos sure thing

@cskinfill
Copy link

We recently upgraded fomr 6.x to 7.9 and are running in to this problem. Any fix we can apply locally? Or any movement on this issue?

@timroes timroes added Feature:Filters and removed Feature:Discover Discover Application labels Sep 10, 2020
@lizozom
Copy link
Contributor

lizozom commented Oct 4, 2020

@cskinfill The issue is tracked under elastic/eui#2082
It's currently labeled as urgent, I encourage you to vote it up and track it there.

@asanfilov
Copy link

Version 7.10.2 still has the same UI issue. Please fix it.

2023-05-08 11_21_35-Discover - Elastic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Feature:Filters Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants