[Infra] Show all alerts in Infra views (Host + Containers) for consistency with entity inventory #202188

rmyz · 2024-11-28T15:01:26Z

Summary

Closes #201567
Fixes #181580 and #201528

This PR ensures that Infra views display all alerts, regardless of index pattern.
It provides consistent alert visibility across services.

Alert counts per host in the Hosts List now shows all host alerts
Alert counts in alerting tab in Hosts List now shows all host alerts
Hosts Views now shows all host alerts
Container Views now shows all container alerts
Alert counts shown in Hosts Lists and Host Views now are consistent with alerting app when filtered by host
Clicking through alerts in host/container views now filters by just the entity ID
Clicking Show all in Hosts now goes to Alerts app with all hosts that have alerts in the filter
Clicking an Alert in Entity Inventory now searches by just the entity ID

Screenshots

Screen	Before	After
Entity inventory (no changes here, just showing the alert count for next screens)
Host detail view
Host List view
Container detail view
Click `Show all` in Host List
Click `Show all` in Host/Container detail view
Click alert in Entity Inventory

rmyz · 2024-11-28T15:07:56Z

...lugins/observability_solution/inventory/public/components/alerts_badge/alerts_badge.test.tsx

    );
    expect(screen.queryByTestId('inventoryAlertsBadgeLink')?.textContent).toEqual('5');
  });
-  it('render alerts badge for a service entity with multiple identity fields', () => {


Removing this test as we don't have that functionality anymore

github-actions · 2024-11-28T15:08:12Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

rmyz · 2024-11-28T15:10:08Z

CC @roshan-elastic in case you want to see the screenshots

roshan-elastic · 2024-11-28T15:44:44Z

CC @roshan-elastic in case you want to see the screenshots

THANK YOU! Having just the PRs I need to see without needing to go further than here saves me SO much time ❤️

cauemarcondes

LGTM, just a nit

...lity_solution/infra/public/pages/metrics/hosts/components/tabs/alerts/alerts_tab_content.tsx

…cs/hosts/components/tabs/alerts/alerts_tab_content.tsx Co-authored-by: Cauê Marcondes <[email protected]>

crespocarlos

LGTM

iblancof · 2024-11-29T12:23:57Z

...lity_solution/infra/public/pages/metrics/hosts/components/tabs/alerts/alerts_tab_content.tsx

@@ -63,7 +69,7 @@ export const AlertsTabContent = () => {
              <LinkToAlertsPage
                dateRange={searchCriteria.dateRange}
                data-test-subj="infraHostAlertsTabAlertsShowAllButton"
-                kuery={`${ALERT_RULE_PRODUCER}: ${INFRA_ALERT_FEATURE_ID}`}
+                kuery={`${hostsWithAlertsKuery}`}


Are we sure we want to filter by this?

The query's scalability has changed, and instead of showing all alerts across hosts, we're now only displaying alerts for specific hosts. This could limit the visibility we might need.

Any thoughts?

well, as the previous query would only show alerts that were created inside infra, now we are filtering by all the hosts that have more than 1 alert. This maintains the alert count we are showing everywhere

jennypavlova

LGTM, just nits ⬇️

x-pack/plugins/observability_solution/infra/common/constants.ts

x-pack/plugins/observability_solution/infra/public/components/shared/alerts/constants.ts

x-pack/plugins/observability_solution/inventory/public/components/alerts_badge/alerts_badge.tsx

elasticmachine · 2024-11-29T15:02:49Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: bee9a26
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-202188-bee9a2634649

Failed CI Steps

Jest Tests #11

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`infra`	1.8MB	1.8MB	-298.0B
`inventory`	236.8KB	236.7KB	-81.0B
total			-379.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`infra`	56.5KB	56.9KB	+418.0B

History

💚 Build #255534 succeeded eb0e32b
💔 Build #255403 failed 1e1d655

cc @rmyz

kibanamachine · 2024-11-29T15:46:16Z

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12087516249

…tency with entity inventory (elastic#202188) ## Summary Closes elastic#201567 Fixes elastic#181580 and elastic#201528 This PR ensures that Infra views display all alerts, regardless of index pattern. It provides consistent alert visibility across services. - **Alert counts per host in the Hosts List now shows all host alerts** - **Alert counts in alerting tab in Hosts List now shows all host alerts** - **Hosts Views now shows all host alerts** - **Container Views now shows all container alerts** - **Alert counts shown in Hosts Lists and Host Views now are consistent with alerting app when filtered by host** - **Clicking through alerts in host/container views now filters by just the entity ID** - **Clicking `Show all` in `Hosts` now goes to Alerts app with all hosts that have alerts in the filter** - **Clicking an Alert in Entity Inventory now searches by just the entity ID** ## Screenshots Screen|Before|After -|-|- Entity inventory (no changes here, just showing the alert count for next screens)|<img width="1276" alt="image" src="https://github.com/user-attachments/assets/e6054957-b9d8-4d19-8ce3-b101f60099a2">|<img width="772" alt="image" src="https://github.com/user-attachments/assets/2b64fb4d-ff60-4c6b-8e15-3ccb5ae6621b"> Host detail view|<img width="662" alt="image" src="https://github.com/user-attachments/assets/0dd405bc-888a-4fd0-9412-6016e8ae3795">|<img width="775" alt="image" src="https://github.com/user-attachments/assets/bf694b1d-b7bb-4cc8-abd1-bebb2070d11c"> Host List view|<img width="536" alt="image" src="https://github.com/user-attachments/assets/a9c7ae89-8549-49d0-aeb3-3dc28dd3f713"><img width="894" alt="image" src="https://github.com/user-attachments/assets/38433bfb-66b0-4c08-824a-ccf46ad93e50">|<img width="582" alt="image" src="https://github.com/user-attachments/assets/7addf149-9f12-45a3-b443-9cd069edc4a9"><img width="731" alt="image" src="https://github.com/user-attachments/assets/51e80e6c-504b-40b0-80b7-a9a58a6ad153"> Container detail view|<img width="676" alt="image" src="https://github.com/user-attachments/assets/851cafec-d580-4184-a7a1-7b87620ea1b4">|<img width="698" alt="image" src="https://github.com/user-attachments/assets/aebdd4f5-26f1-4b74-8cf4-37dc74aad112"> Click `Show all` in Host List|<img width="696" alt="image" src="https://github.com/user-attachments/assets/0557f9f8-aee3-4898-be17-372f3522f160">|<img width="1096" alt="image" src="https://github.com/user-attachments/assets/c5ace835-a56b-45cb-95c7-fa978d7840f5"> Click `Show all` in Host/Container detail view|<img width="712" alt="image" src="https://github.com/user-attachments/assets/eb04c059-aff0-48f4-90fb-73c08943cb57">|<img width="748" alt="image" src="https://github.com/user-attachments/assets/189f686d-5931-4f42-bf14-ac9f1ae987e4"> Click alert in Entity Inventory|<img width="677" alt="image" src="https://github.com/user-attachments/assets/e99f70a1-c217-4225-acf4-25285fff8282">|<img width="637" alt="image" src="https://github.com/user-attachments/assets/9aa77aa4-7a77-45ac-8cf4-95b5203d0f5a"> --------- Co-authored-by: Cauê Marcondes <[email protected]> (cherry picked from commit a882b2c)

kibanamachine · 2024-11-29T15:51:06Z

💚 All backports created successfully

Status	Branch	Result
✅	8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…consistency with entity inventory (#202188) (#202336) # Backport This will backport the following commits from `main` to `8.x`: - [[Infra] Show all alerts in Infra views (Host + Containers) for consistency with entity inventory (#202188)](#202188)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  Co-authored-by: Sergi Romeu <[email protected]>

rmyz added 2 commits November 28, 2024 13:09

refactor: show all alerts in infra

b4fd22e

refactor: redirect to alerts only with entity id

0dda3e7

rmyz self-assigned this Nov 28, 2024

rmyz added release_note:fix backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Nov 28, 2024

rmyz marked this pull request as ready for review November 28, 2024 15:06

rmyz requested a review from a team as a code owner November 28, 2024 15:06

rmyz requested a review from iblancof November 28, 2024 15:06

rmyz commented Nov 28, 2024

View reviewed changes

botelastic bot added the ci:project-deploy-observability Create an Observability project label Nov 28, 2024

refactor: use shared constant for infra alerts featureids

5e74a6f

cauemarcondes approved these changes Nov 28, 2024

View reviewed changes

...lity_solution/infra/public/pages/metrics/hosts/components/tabs/alerts/alerts_tab_content.tsx Outdated Show resolved Hide resolved

Update x-pack/plugins/observability_solution/infra/public/pages/metri…

1e1d655

…cs/hosts/components/tabs/alerts/alerts_tab_content.tsx Co-authored-by: Cauê Marcondes <[email protected]>

crespocarlos approved these changes Nov 29, 2024

View reviewed changes

rmyz added 2 commits November 29, 2024 11:32

test: fix tests

e2b819b

Merge branch 'main' into 201567-infra-fix-alerts

eb0e32b

iblancof mentioned this pull request Nov 29, 2024

[APM] Show all alerts in service views & service inventory for consistency with entity inventory #202025

Merged

iblancof reviewed Nov 29, 2024

View reviewed changes

jennypavlova approved these changes Nov 29, 2024

View reviewed changes

refactor: apply PR comments

bee9a26

rmyz enabled auto-merge (squash) November 29, 2024 14:16

rmyz merged commit a882b2c into elastic:main Nov 29, 2024
8 checks passed

kibanamachine added the v9.0.0 label Nov 29, 2024

kibanamachine mentioned this pull request Nov 29, 2024

[8.x] [Infra] Show all alerts in Infra views (Host + Containers) for consistency with entity inventory (#202188) #202336

Merged

kibanamachine added the v8.18.0 label Nov 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Infra] Show all alerts in Infra views (Host + Containers) for consistency with entity inventory #202188

[Infra] Show all alerts in Infra views (Host + Containers) for consistency with entity inventory #202188

rmyz commented Nov 28, 2024 •

edited by kibanamachine

Loading

rmyz Nov 28, 2024

github-actions bot commented Nov 28, 2024

rmyz commented Nov 28, 2024

roshan-elastic commented Nov 28, 2024

cauemarcondes left a comment

crespocarlos left a comment

iblancof Nov 29, 2024

rmyz Nov 29, 2024

jennypavlova left a comment

elasticmachine commented Nov 29, 2024 •

edited

Loading

kibanamachine commented Nov 29, 2024

kibanamachine commented Nov 29, 2024

[Infra] Show all alerts in Infra views (Host + Containers) for consistency with entity inventory #202188

[Infra] Show all alerts in Infra views (Host + Containers) for consistency with entity inventory #202188

Conversation

rmyz commented Nov 28, 2024 • edited by kibanamachine Loading

Summary

Screenshots

rmyz Nov 28, 2024

Choose a reason for hiding this comment

github-actions bot commented Nov 28, 2024

🤖 GitHub comments

rmyz commented Nov 28, 2024

roshan-elastic commented Nov 28, 2024

cauemarcondes left a comment

Choose a reason for hiding this comment

crespocarlos left a comment

Choose a reason for hiding this comment

iblancof Nov 29, 2024

Choose a reason for hiding this comment

rmyz Nov 29, 2024

Choose a reason for hiding this comment

jennypavlova left a comment

Choose a reason for hiding this comment

elasticmachine commented Nov 29, 2024 • edited Loading

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Page load bundle

History

kibanamachine commented Nov 29, 2024

kibanamachine commented Nov 29, 2024

💚 All backports created successfully

Questions ?

rmyz commented Nov 28, 2024 •

edited by kibanamachine

Loading

elasticmachine commented Nov 29, 2024 •

edited

Loading