[8.x] Set min-width for DistributionBar and added README for storybook (#202247) #202366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stic#202247) ## Summary - This pull request resolves [elastic#200881](elastic#200881) by setting a min-width of 10px for the DistributionBar component to prevent it from shrinking too small, ensuring a consistent and readable visual representation for better usability. - Additionally, added a README file with instructions for running Storybook to visually inspect the DistributionBar, as the folder had no documentation before, improving the developer experience. ## Screenshots: **Before** - The min-width of 10px was set, but small segments were not visible in the DistributionBar.  - The original mockStatsFindings with 'passed' set to 90 and 'failed' set to 10 did not visually reflect the min-width of 10px in the DistributionBar. The smallest segment was still not visible.  **After**: - Temporarily modified the `mockStatsFindings` in `distribution_bar.stories.tsx` to simulate the DistributionBar with extreme values by setting the count for 'passed' to 9000 (highest) and 'failed' to 1 (lowest):  - After the modification, the DistributionBar displayed correctly with even the smallest segments visible, confirming that the min-width is working as expected.  - These results were captured in a screenshot for the PR, and no changes were saved to the `distribution_bar.stories.tsx` file. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 50a2ffa)
2 tasks
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
💚 Build Succeeded
Metrics [docs]Async chunks
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation