Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the :deprecate modifier of config DSL to log on deprecation logger #14988

Open
andsel opened this issue Apr 4, 2023 · 2 comments
Open

Comments

@andsel
Copy link
Contributor

andsel commented Apr 4, 2023

Context

The deprecation logger (which outputs in logs/logstash-deprecation.log is intended to list all the deprecation statements that would help a user to fix their pipelines to be future proof.

Change requested

The :deprecation modifier which used in plugin's config DSL logs the warnings on the main Logstash's logger and not the deprecation one.
For example the setting definitions:

config :ssl, :validate => :boolean, :default => false, :deprecated => "Set 'ssl_enabled' instead."

generates the following line on the logs/logstash-plain.log

[2023-04-04T17:26:32,548][WARN ][logstash.inputs.http     ] You are using a deprecated config setting "ssl" set in http. Deprecated settings will continue to work, but are scheduled for removal from logstash in the future. Set 'ssl_enabled' instead. If you have any questions about this, please visit the #logstash channel on freenode irc. {:name=>"ssl", :plugin=><LogStash::Inputs::Http....

which instead should go on the deprecation logger.

@andsel
Copy link
Contributor Author

andsel commented Apr 4, 2023

cc @roaksoax

@robbavey
Copy link
Member

Please verify that plugin deprecation warnings go to the deprecation logger, and not just the regular logger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants