-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NPE when getting native thread id #15301
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaisecheng
force-pushed
the
fix_agent_test_NPE
branch
from
September 4, 2023 12:51
917f8fc
to
a336484
Compare
kaisecheng
changed the title
Fix agent_spec NPE when getting native thread id
Fix NPE when getting native thread id
Sep 5, 2023
roaksoax
approved these changes
Sep 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@logstashmachine backport 8.10 |
@logstashmachine backport 7.17 |
kaisecheng
added a commit
that referenced
this pull request
Sep 14, 2023
This commit adds null guard to get the native thread when constructing pipeline report Fix: #15300 (cherry picked from commit cd78558) Co-authored-by: kaisecheng <[email protected]>
kaisecheng
added a commit
that referenced
this pull request
Sep 14, 2023
This commit adds null guard to get the native thread when constructing pipeline report Fix: #15300 (cherry picked from commit cd78558) Co-authored-by: kaisecheng <[email protected]>
dliappis
pushed a commit
to dliappis/logstash
that referenced
this pull request
Sep 20, 2023
This commit adds null guard to get the native thread when constructing pipeline report Fix: elastic#15300
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #15300, #14961
The tests fail to shutdown old pipeline when the native thread returns null. It throws NPE when constructing pipeline report