[ci] Don't trigger BK PR jobs on pushes #15426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently while PR jobs get triggered as expected in Buildkite via the bot, they also get re-triggered after something gets pushed, including e.g. the squash merge commit when the PR is merged. This commit disables this behavior as documented in Buildkite[^1]. Relates: - elastic#15402 - elastic/ingest-dev#1721 [^1]: https://buildkite.com/docs/apis/rest-api/pipelines
alexsapran
reviewed
Oct 11, 2023
catalog-info.yaml
Outdated
| @@ -243,7 +243,8 @@ spec: | |||
| provider_settings: | |||
| build_pull_request_forks: false | |||
| build_pull_requests: true # requires filter_enabled and filter_condition settings as below when used with buildkite-pr-bot | |||
| build_tags: true | |||
| build_branches: false | |||
| build_tags: false | |||
| filter_enabled: true | |||
| filter_condition: >- | |||
| build.pull_request.id == null || (build.creator.name == 'elasticmachine' && build.pull_request.id != null) | |||
There was a problem hiding this comment.
This might need adjustment as well. As the filter condition indicates, it will allow the pipeline to trigger when there is no build.pull_request.id which is the case of a branch commit in the base branch, and allow to trigger the pipeline when the creator iselasticmachine for the event of a PR.
I would change this and keep only the right side of the || meaning
Suggested change
| build.pull_request.id == null || (build.creator.name == 'elasticmachine' && build.pull_request.id != null) | |
| build.creator.name == 'elasticmachine' && build.pull_request.id != null |
There was a problem hiding this comment.
Thank you! Addressed in d23aa37
There was a problem hiding this comment.
As discussed offline, I left build_branches and build_tags set to false as well.
|
SonarQube Quality Gate
|
alexsapran
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
[rn:skip]
What does this PR do?
Currently while PR jobs get triggered as expected in Buildkite via the bot, they also get re-triggered after something gets pushed, including e.g. the squash merge commit when the PR is merged.
This commit disables this behavior as documented in Buildkite1.
Related issues
Footnotes
https://buildkite.com/docs/apis/rest-api/pipelines ↩