Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin psych 5.1.0 due to ruby/psych#655 #15433

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Conversation

jsvd
Copy link
Member

@jsvd jsvd commented Oct 11, 2023

The new psych 5.1.1 gem seems to not work when installed in JRuby 9.4 (used in main).

This change pins the version back to 5.1.0 until ruby/psych#655 is sorted.

Closes #15427

@dliappis dliappis self-requested a review October 11, 2023 13:55
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

Can we add in the description that it closes #15427 ?

@elastic-sonarqube
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dliappis
Copy link
Contributor

The license check passes with this PR -> https://buildkite.com/elastic/logstash-pull-request-pipeline/builds/31

@jsvd jsvd merged commit 401d166 into elastic:main Oct 11, 2023
2 checks passed
@jsvd jsvd deleted the pin_psych_5_1_0 branch October 11, 2023 13:58
@jsvd
Copy link
Member Author

jsvd commented Oct 11, 2023

@logstashmachine backport 8.11

github-actions bot pushed a commit that referenced this pull request Oct 11, 2023
The new psych 5.1.1 gem seems to not work when installed in JRuby 9.4 (used in main).

This change pins the version back to 5.1.0 until ruby/psych#655 is sorted.

(cherry picked from commit 401d166)
jsvd added a commit that referenced this pull request Oct 12, 2023
The new psych 5.1.1 gem seems to not work when installed in JRuby 9.4 (used in main).

This change pins the version back to 5.1.0 until ruby/psych#655 is sorted.

(cherry picked from commit 401d166)

Co-authored-by: João Duarte <[email protected]>
@jsvd
Copy link
Member Author

jsvd commented Oct 12, 2023

@logstashmachine backport 8.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to run dependencies-report -- reporting cannot load (ext) (org.jruby.ext.psych.PsychLibrary)
2 participants