Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change DLQ classes to be unaware of time #15594

Closed
andsel opened this issue Nov 16, 2023 · 0 comments · Fixed by #15680
Closed

Change DLQ classes to be unaware of time #15594

andsel opened this issue Nov 16, 2023 · 0 comments · Fixed by #15680
Assignees

Comments

@andsel
Copy link
Contributor

andsel commented Nov 16, 2023

Referring to issue #15562 where a test related to timing constraint proved to be fragile, drive to this request.
The request is to rework the DeadLetterQueueWriter to abstract from physical time, so that test can be done in full control of time.
In such case, the tests doesn't need anymore to create assertions like "this condition has to be met in 1 second but no more that 10", because in that case the test would be synchronous, and not depend on physical time events. Such time events, that trigger the execution of a code block, should be trigger by something external, and in tests it could be used a fake that trigger such events on command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants