Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Skip slack alerts if retried tasks succeeded #15869

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

dliappis
Copy link
Contributor

@dliappis dliappis commented Jan 29, 2024

Release notes

[rn:skip]

What does this PR do?

Currently for pipelines that have steps with auto retries, if there is a failure of a step, even if the subsequent retry succeeds, we receive Slack alerts.
This commits uses new functionality1 available in the Buildkite PR Bot to avoid Slack notifications in those cases and changes the settings for all pipelines where we have, or expect to have, retries.

Why is it important/What is the impact to the user?

Reduce alert noise for non-actionable events in the Slack channel.

How to test this PR locally

Can't be tested, needs to be merged for the change to get picked up by terrazzo.

Footnotes

  1. https://github.com/elastic/kibana-buildkite-build-bot/commit/95102e37dd14e95cf8c5eb32a4027d6b14f3fb73

Currently for pipelines that have steps with auto retries, if there
is a failure of a step, even if the subsequent retry succeeds, we
received Slack alerts.
This commits uses new functionality available in the Buildkite PR Bot
to avoid Slack notifications in those cases and changes the settings
for all pipelines where we have, or expect to have, retries.
@dliappis dliappis added the ci label Jan 29, 2024
@dliappis dliappis requested review from jsvd and alexsapran January 29, 2024 11:23
@dliappis dliappis self-assigned this Jan 29, 2024
Copy link
Member

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, yay noise reduction.

Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @dliappis

@dliappis dliappis merged commit 70c3fcd into elastic:main Jan 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants