-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated SSL settings from Logstash core #16652
Comments
In order to get the shape and scope of this I compiled a list of all the deprecates ssl options i've seen so far in the plugin work and searched a copy of a logstash checkout. There are obviously quite a few false positives (ssl is going to be a very popular one 😅 ). I've attached the hist and where they appear. I will be going through them and first removing obvious false positives. I'll then move on to classifying/organising the rest of the occurances. Let me know if i'm way over-thinking this though!
|
That definitely seems like a fair few false positives... We can skip anything modules related for a start with #16794 in flight What we want to do here is ensure that we:
|
The part I originally missed is that the keys in the mappings (IE the value we set when configuring these on the LS side) are not changing, its the translation of those into the settings used by the underlying plugins. I went through and confirmed that everywhere we need to do a translation is now doing so with modern/standardized ssl settings for plugins.
I was unable to find any plugin ssl settings that are carrying a deprecation warnings in LS.
Verified the linkede PR was complete and no deprecations need to be promoted to obsolete/removed. (Thank you BTW for linking this PR as this was the key to me understanding the scope of this work).
This is a noop
I did not find any external facing deprecations/removals to document. My overall findings for this ticket is that it is resulting in a noop. It is always hardest to prove a negative, but i'm just not finding anything that needs to be removed as part of 9.0.0 relating to ssl setting standardization. |
Perfect - thank you. You can close this issue, unless you have any further questions |
[ ] Enumerate deprecated SSL settings in core[ ] Ensure that all unit and integration tests still pass[ ] Add details of change to the 9.0 breaking changes documentation in core.See #16652 (comment) for write up, but I was unable to identify any actions required for the steps listed in this ticket.
The text was updated successfully, but these errors were encountered: