Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release notes for 8.17.0 #16768

Merged
merged 7 commits into from
Dec 11, 2024
Merged

Release notes for 8.17.0 #16768

merged 7 commits into from
Dec 11, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Dec 9, 2024 •
edited by karenzone
Loading

@jsvd jsvd requested review from jsvd and removed request for jsvd December 9, 2024 16:30
@karenzone karenzone mentioned this pull request Dec 9, 2024
Open
11 tasks
@jsvd jsvd marked this pull request as ready for review December 11, 2024 15:43
robbavey
robbavey requested changes Dec 11, 2024
View reviewed changes
Copy link
Member

@robbavey robbavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion to fix build and link/link text disconnect

docs/static/releasenotes.asciidoc Outdated Show resolved Hide resolved
docs/static/releasenotes.asciidoc Outdated Show resolved Hide resolved
@jsvd jsvd requested a review from robbavey December 11, 2024 16:17
robbavey
robbavey approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@robbavey robbavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming green docs build

@jsvd
Copy link
Member

jsvd commented Dec 11, 2024 •
edited
Loading

Got an error in CI after the docs build ran (apparently successfully):

INFO:build_docs: ! [remote rejected] logstash_bk_16768 -> logstash_bk_16768 (cannot lock ref 'refs/heads/logstash_bk_16768': is at d3202f5286e2764572928f55d303b636a6b862d5 but expected 3c12ce04b1c8131993ac664129723b6c46363081)

Retrying: https://buildkite.com/elastic/docs-build-pr/builds/208973#0193b6ab-1727-4020-8952-151d23f467a9

@donoghuc
Copy link
Member

I saw a similar issue updating a remote in #16778


INFO:build_docs: ! [rejected]                    logstash_bk_16778 -> logstash_bk_16778 (fetch first)
--
  | INFO:build_docs:error: failed to push some refs to '[email protected]:elastic/built-docs'
  | INFO:build_docs:hint: Updates were rejected because the remote contains work that you do
  | INFO:build_docs:hint: not have locally. This is usually caused by another repository pushing
  | INFO:build_docs:hint: to the same ref. You may want to first integrate the remote changes
  | INFO:build_docs:hint: (e.g., 'git pull ...') before pushing again.
  | INFO:build_docs:hint: See the 'Note about fast-forwards' in 'git push --help' for details.
  | INFO:build_docs:
  | INFO:build_docs:---------

@jsvd
Copy link
Member

jsvd commented Dec 11, 2024

@elasticmachine run docs-build

or whatever the incantation is

@jsvd jsvd closed this Dec 11, 2024
@jsvd jsvd reopened this Dec 11, 2024
@robbavey robbavey merged commit f663392 into 8.17 Dec 11, 2024
5 checks passed
@robbavey robbavey deleted the update_release_notes_1733761634 branch December 11, 2024 22:38
@edmocosta
Copy link
Contributor

@logstashmachine backport 8.x

github-actions bot added a commit that referenced this pull request Dec 12, 2024
@github-actions @logstashmachine
Release notes for 8.17.0 (#16768)
30b26a5 
* Update release notes for 8.17.0

---------

Co-authored-by: logstashmachine <[email protected]>
Co-authored-by: João Duarte <[email protected]>
Co-authored-by: Rob Bavey <[email protected]>
(cherry picked from commit f663392)
@github-actions github-actions bot mentioned this pull request Dec 12, 2024
Merged
jsvd pushed a commit that referenced this pull request Dec 16, 2024
@github-actions
Release notes for 8.17.0 (#16768) (#16789)
38e1618 
* Update release notes for 8.17.0

---------

Co-authored-by: logstashmachine <[email protected]>
Co-authored-by: João Duarte <[email protected]>
Co-authored-by: Rob Bavey <[email protected]>
(cherry picked from commit f663392)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsvd jsvd jsvd left review comments

@robbavey robbavey robbavey approved these changes

Assignees

@jsvd jsvd

Labels
v8.18.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jsvd @donoghuc @edmocosta @robbavey @logstashmachine