Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that sensible Jackson defaults are applied at startup #16773

Open
robbavey opened this issue Dec 9, 2024 · 0 comments
Open

Ensure that sensible Jackson defaults are applied at startup #16773

robbavey opened this issue Dec 9, 2024 · 0 comments

Comments

@robbavey
Copy link
Member

robbavey commented Dec 9, 2024

Logstash 8.12.0 added properties with increased defaults to config/jvm.options, to ensure that Logstash would continue to run correctly after a change to Jackson imposed a number of read constraints (Maximum Number value length, Maximum String value length, and Maximum Nesting depth).

While this change would be applied for users using a fresh version of config/jvm.options, users who have previously made changes to config/jvm.options, or users who are managing their own config/jvm.options would not get these changes after an upgrade, as the original file would be left in tact.

This can be problematic, as the default maximum allowed size by Jackson may be too small, which may result in issues such as #16683, when reading events.

We should ensure that a sensible default, as provided in the original additions to config/jvm.options, is applied at runtime if no setting is included. This is something we already do for the Netty maxOrder value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant