Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise an Error for Duplicate Hash Keys in Plugin Configs #8605

Open
original-brownbear opened this issue Nov 8, 2017 · 2 comments
Open

Raise an Error for Duplicate Hash Keys in Plugin Configs #8605

original-brownbear opened this issue Nov 8, 2017 · 2 comments

Comments

@original-brownbear
Copy link
Member

original-brownbear commented Nov 8, 2017

Follow up to #8597

We want to stop supporting this:

foo => { "bar" => "hello" }
foo => { "baz" => "goodbye" }

which currently gets interpreted as:

foo => {
  "bar" => "hello"
  "baz" => "goodbye"
}

and instead, want to raise a config error when encountering a duplicate key in a plugin config.

Also as @jordansissel mentions below:

[...] we should also add this to 6.x but instead of an error (as in 7.0) it logs a warning w/ how to fix the issue.


Note that this is supposed to only be merged to 7.x (master as of the time of writing) not 6.x.

@jordansissel
Copy link
Contributor

jordansissel commented Nov 8, 2017

@original-brownbear we should also add this to 6.x but instead of an error (as in 7.0) it logs a warning w/ how to fix the issue.

@original-brownbear
Copy link
Member Author

@jordansissel thanks, added it to the issue :)

@jsvd jsvd removed the v6.1.0 label Sep 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants