-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Applying group data to Mail object #72
Comments
@dhakan, I don't think this is supported by this library at the moment. Could you post an example to test/implement against? I've not attempted unsubscribe groups through this package before, but shouldn't be too challenging to add. Only a few fields in the API endpoint are implemented right now:
For ref: https://sendgrid.com/docs/API_Reference/Web_API_v3/Mail/index.html |
I see, so it looks like my understanding was correct. I'll see what I can do and keep you posted :) |
I'm kind of new to python module distribution. So far I've managed to run |
@dhakan here's an example of an easy way to demonstrate an issue if you can replicate: https://github.com/jayhale/sendgrid-django-61 @danniehakan this package tests against (https://github.com/elbuo8/sendgrid-django/blob/master/.travis.yml): Django:
Python:
It will work with more Django versions, but just isn't tested against all of them. The package doesn't depend on Django - rather Django depends on the package to supply an email backend. |
Ok, so I've integrated this functionality in my own fork along with proper test coverage. Do I just PR my forked master to this repo, or do I create an issue in the same way you've done here? |
I've been digging through the source and cannot find a way of sending
"asm": {"group_id": 1}
along the request in order to associate a specific unsubscribe link to the user in the mail being sent.Is this possible? If not, why? And what about all of the other fields in the v3 /mail/send endpoint?
The text was updated successfully, but these errors were encountered: