Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom dialog #97

Closed

Conversation

ArthurLobopro
Copy link

@ArthurLobopro ArthurLobopro commented Nov 6, 2022

Hi, I've added a custom text to notify dialog. That can help users from other countries that wish only to switch language of buttons or other small changes to the text.

@erickzhao erickzhao requested a review from a team November 7, 2022 17:30
Copy link
Member

@BlackHole1 BlackHole1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ArthurLobopro
Copy link
Author

someone here?

Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of unnecessary formatting changes in the index.d.ts that should be cleaned up.

There's a PR open that converts this module to TS though so this should maybe land after #105

@ArthurLobopro
Copy link
Author

Oh, sorry. My vscode was set to remove semicolons.

@jordanamr
Copy link

Hello, any news on merging that PR ? :)

@ArthurLobopro
Copy link
Author

Apparently no.

@erikian
Copy link
Member

erikian commented Oct 23, 2023

Superseded by #126

@erikian erikian closed this Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants