Use tag instead of main branch when importing tokens #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also do not clone the whole project, but just the tag.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57 +/- ##
=======================================
Coverage 85.72% 85.72%
=======================================
Files 23 23
Lines 2725 2725
Branches 224 224
=======================================
Hits 2336 2336
Misses 181 181
Partials 208 208 ☔ View full report in Codecov by Sentry. |
jmartinesp
approved these changes
Jul 5, 2024
jmartinesp
requested changes
Jul 5, 2024
| BRANCH='main' | ||
| SHORT=t,: | ||
| LONG=tag,: | ||
| TAG='v1.4.0' |
There was a problem hiding this comment.
Wait, are we sure about this? I'd either set main as default or force the user to input a tag.
There was a problem hiding this comment.
I think that to properly handle https://element-io.atlassian.net/browse/PSB-700 we should just have an hard-coded value of the tag somewhere and not allow passing it as command line parameter, to avoid any mistake. WDYT @giomfo
| esac | ||
| done | ||
|
|
||
| echo "Branch used: $BRANCH" | ||
| echo "Tag used: $TAG" |
There was a problem hiding this comment.
Maybe use 'Ref' instead of tag?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to ensure traceability of the token version used per release, use a tag to import the Compound tokens.
Note that it's still possible to use a branch name for testing purpose only.
Also change
vector-imtoelement-hqin the whole project.Related to https://element-io.atlassian.net/browse/PSB-700