Implement macos title bar negative space #1272
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1245
Needs matrix-org/matrix-react-sdk#11735 to land before this pull request
All the
drag
regions do not delegate the hover state to the web page. Which means the new room header would only trigger its hover state forno-drag
zones. This does not allow us to implement the experience that we wish to provide.We have decide to implement this compromise that adds negative space at the top of the application where you can drag the window around. This is a compromise and a step in the right direction until we have enough time to redesign the top bar and implement something more constructive rather than empty space.
Checklist
Here's what your changelog entry will look like:
✨ Features