Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement macos title bar negative space #1272

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

germain-gg
Copy link
Contributor

@germain-gg germain-gg commented Oct 11, 2023

Fixes #1245
Needs matrix-org/matrix-react-sdk#11735 to land before this pull request

Screenshot 2023-10-11 at 11 11 31 Screenshot 2023-10-11 at 17 55 01

All the drag regions do not delegate the hover state to the web page. Which means the new room header would only trigger its hover state for no-drag zones. This does not allow us to implement the experience that we wish to provide.

We have decide to implement this compromise that adds negative space at the top of the application where you can drag the window around. This is a compromise and a step in the right direction until we have enough time to redesign the top bar and implement something more constructive rather than empty space.

Checklist

  • Ensure your code works with manual testing
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Here's what your changelog entry will look like:

✨ Features

Copy link
Contributor

@weeman1337 weeman1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with the React SDK branch and works 👍

Only a small note: I would prefer all elements at the top to be aligned. Not the user avatar, search box and room header are not aligned:

image

@germain-gg germain-gg merged commit 507fd77 into develop Oct 12, 2023
24 checks passed
@germain-gg germain-gg deleted the germain-gg/electron-negative-space branch October 12, 2023 14:14
@janogarcia
Copy link

@weeman1337 All of those should align to the same keyline. That looks like a bug. Do you get the same output in Electron?

@weeman1337
Copy link
Contributor

@weeman1337 All of those should align to the same keyline. That looks like a bug. Do you get the same output in Electron?

This is how it currently looks like with the old room header

image

New room header:

image

Note that the spacing above is intentional to reserve space for the window controls. They are not visible in my environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mac os header bar
3 participants