Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Nightly builds not bailing on failure #1289

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Fix Nightly builds not bailing on failure #1289

merged 1 commit into from
Oct 23, 2023

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Oct 23, 2023 •
edited by github-actions bot
Loading

Should fix cases like https://github.com/vector-im/element-desktop/actions/runs/6611065784

This change is marked as an internal change (Task), so will not be included in the changelog.

@t3chguy t3chguy added the T-Task Tasks for the team like planning label Oct 23, 2023
@t3chguy t3chguy requested a review from a team as a code owner October 23, 2023 10:29
@t3chguy t3chguy self-assigned this Oct 23, 2023
germain-gg
germain-gg approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@t3chguy t3chguy merged commit ca0a481 into develop Oct 23, 2023
29 checks passed
@t3chguy t3chguy deleted the t3chguy/fix-nightly-failure branch October 23, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@germain-gg germain-gg germain-gg approved these changes

Assignees

@t3chguy t3chguy

Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t3chguy @germain-gg