Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the configure_workers_and_start.py script used internally by Complement. #16650

Open
matrixbot opened this issue Dec 21, 2023 · 0 comments

Comments

@matrixbot
Copy link
Collaborator

matrixbot commented Dec 21, 2023

This issue has been migrated from #16650.


Base: develop

This pull request is intended for commit-by-commit review.

Original commit schedule, with full messages:

  1. Remove obsolete "app" from worker templates

  2. Convert worker templates into dataclass

  3. Use a lambda for the worker name rather than search and replace later

  4. Collapse WORKERS_CONFIG by removing entries with defaults

  5. Convert listener_resources and endpoint_patterns to Set[str]

  6. Tweak comments

  7. Add merge_into

  8. Remove special logic for adding stream_writers: just make it part of the extra config template

  9. Rename function to add_worker_to_instance_map given reduction of scope

  10. Add sharding_allowed to the WorkerTemplate rather than having a separate function for that

  11. Use merge_into when adding workers to the shared config

  12. Promote mark_filepath to constant

  13. Add a --generate-only option

@matrixbot matrixbot changed the title Dummy issue Refactor the configure_workers_and_start.py script used internally by Complement. Dec 22, 2023
@matrixbot matrixbot reopened this Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant