-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REQUEST] Option to manually add image link #1002
Comments
@sk8ordi3 I do not understand what you exactly want. |
after changes in navigation.py
|
In this case it would be importing arts/images from external codes outside of elementum with individual addons, I made this possible solution in the example, then I had to program my addon to replace this line when starting, as the official one doesn't have this function yet, I already gave this idea is 2 years old #886. 😅 |
@GladistonXD It I understand your solution - it would just take currently selected item and use it for Player info. But if you would be in a Youbute, for example, and start a playback remotely - you would have information from that Youtube selected item. Right? |
You have not answered what you want to achieve and why. |
Yes, on YouTube, yes, the problem is when using the plugin://plugin.video.elementum/play?uri="+magnet to launch a code magnet outside the elementum, it only captures the setInfo, the SetArt is not captured, only I managed to capture it, I changed the code to pull via xbmc.getInfoLabel("ListItem.Art(poster)") |
But how you get other infolabels into Player? They idea is that when player is started, it gets mediatype information with id (like "Movie" + TMDB ID), then That is why once you start something externally - it does not have any infolabels, only the file name or torrent name (as that is the only thing we know). Question is how you start player. By calling with plugin path, or by calling Elementum's Python method directly to start a player? |
That is interesting. Where it gets description? |
Yes, I understand, but in this case, films for which there is no TMDB information are not shown despite the information being included directly from the source: listem = xbmcgui.ListItem()
listem.setLabel(name)
listem.setInfo(type="video", infoLabels={"mediatype": "movie", "Title": name, "Plot": info})
listem.setArt({"thumb": iconimage,"poster": iconimage,"tvshowposter": iconimage,"banner": iconimage,"fanart": iconimage,"clearart": iconimage,"clearlogo": iconimage,"landscape" : iconimage,"icon": iconimage}) So I made this change to the source code to capture both: item.setArt({
"thumb": _infoLabels["artthumb"] or xbmc.getInfoLabel("ListItem.Art(thumb)"),
"poster": _infoLabels["artposter"] or xbmc.getInfoLabel("ListItem.Art(poster)"),
"tvshowposter": _infoLabels["arttvshowposter"] or xbmc.getInfoLabel("ListItem.Art(tvshowposter)"),
"banner": _infoLabels["artbanner"] or xbmc.getInfoLabel("ListItem.Art(banner)"),
"fanart": _infoLabels["artfanart"] or xbmc.getInfoLabel("ListItem.Art(fanart)"),
"clearart": _infoLabels["artclearart"] or xbmc.getInfoLabel("ListItem.Art(clearart)"),
"clearlogo": _infoLabels["artclearlogo"] or xbmc.getInfoLabel("ListItem.Art(clearlogo)"),
"landscape": _infoLabels["artlandscape"] or xbmc.getInfoLabel("ListItem.Art(landscape)"),
"icon": _infoLabels["articon"] or xbmc.getInfoLabel("ListItem.Art(icon)")
}) |
Yes, I'm going to create an example of this situation, just a minute. |
@GladistonXD I think we are getting closer to the end :) When player is opening something without TMDB ID, then it goes for So the question is whether we get wrong labels from Kodi, that do not include Art labels (if you say that your ListItem has correct Art items), or we are not properly processing those labels later in Because what you do with your change - it what is already done in |
The execution is more or less this: name = 'Dune 2'
url = 'plugin://plugin.video.elementum/play?uri=magnet:?xt=urn:btih:5B98EEDABB780D1FF58C8A8D5AFB6C234B10757E'
iconimage = 'https://image.tmdb.org/t/p/w342/8LJJjLjAzAwXS40S5mx79PJ2jSs.jpg'
info = 'Paul Atreides (Timothée Chalamet) teams up with Chani (Zendaya) and the Fremen as he seeks revenge...'
item = xbmcgui.ListItem(name, path=url)
item.setInfo('video', infoLabels={'Title': name, 'plot': info})
item.setArt({'thumb': iconimage,'poster': iconimage, 'fanart': iconimage, "icon": iconimage})
xbmcplugin.setResolvedUrl(int(sys.argv[1]), True, item) |
Yes, he receives the titles, just not the images |
When you send anything to
navigation.py
|
In this case, these logs? |
In this case I use an addon called plugin://plugin.video.filmes |
Can you share zip file for that plugin? I cannot find exact source for that plugin. |
I'm going to create an addon with this specific issue and then send the zip here. |
plugin.video.filmes.zip |
It saved me lot of time in testing. Thanks. I pushed a change to Elementum code (elgatito/elementum@6808610) It shows all the information and images with your test addon. No python code changes are needed. |
Ok I'll test it, thanks for your work. 😄 |
@GladistonXD were you able to build a test version of elementum? docs - https://github.com/elgatito/plugin.video.elementum?tab=readme-ov-file#build if not - tell me your platform (e.g. windows_x64, see https://github.com/elgatito/plugin.video.elementum/releases) and i can make a test build for you. |
@antonsoroko |
I didn't compile it to test, it could be windows_x64 |
windows_x64 build of master branch - plugin.video.elementum-v0.1.99-31-gbc63d8e.windows_x64.zip (be aware that it has many other unreleased features, so it is expected that some things are different than in 0.1.99.) |
It worked perfectly, it also removed the bug where the name episode 0* always appeared in front of the title before I used alternative like this 'play?show=""&uri=' to remove this bug. thanks |
I found a problem in this beta version, when the torrent has several episodes embedded, the panel does not open, for example: |
@GladistonXD What do you mean? You add a magnet with multiple files and do not get a dialog to select which file to play? |
Yes of course, I believe it is in the Dialog Select part
|
And what Kodi version is that?
пт, 5 апр. 2024 г., 08:13 GladistonXD ***@***.***>:
… @GladistonXD <https://github.com/GladistonXD> What do you mean? You add a
magnet with multiple files and do not get a dialog to select which file to
play? Can you show a log?
Yes of course, I believe it is in the Dialog Select part
This problem only occurred in this trial version:
2024-04-05 03:04:25.305 T:8480 warning <general>: [plugin.video.elementum] INFO bittorrent ▶ AddTorrent Adding torrent from magnet:?xt=urn:btih:a6dc9a0a59ad352d66775b323fc305b1813dce0d
2024-04-05 03:04:25.305 T:8480 warning <general>: [plugin.video.elementum] INFO bittorrent ▶ AddTorrent Setting save path to .
2024-04-05 03:04:25.305 T:8480 warning <general>: [plugin.video.elementum] NOTI bittorrent ▶ logAlerts add_torrent_alert: added torrent: a6dc9a0a59ad352d66775b323fc305b1813dce0d
2024-04-05 03:04:25.305 T:8480 warning <general>: [plugin.video.elementum] NOTI bittorrent ▶ logAlerts state_changed_alert: a6dc9a0a59ad352d66775b323fc305b1813dce0d: state changed to: dl metadata
2024-04-05 03:04:25.305 T:8480 warning <general>: [plugin.video.elementum] NOTI bittorrent ▶ logAlerts torrent_resumed_alert: a6dc9a0a59ad352d66775b323fc305b1813dce0d resumed
2024-04-05 03:04:25.309 T:8480 warning <general>: [plugin.video.elementum] INFO bittorrent ▶ AddTorrent Setting sequential download to: false
2024-04-05 03:04:25.309 T:8480 warning <general>: [plugin.video.elementum] INFO bittorrent ▶ AddTorrent Adding new torrent item with url: magnet:?xt=urn:btih:a6dc9a0a59ad352d66775b323fc305b1813dce0d
2024-04-05 03:04:25.309 T:8480 warning <general>: [plugin.video.elementum] INFO bittorrent ▶ NewTorrent Adding torrent with storage: Memory
2024-04-05 03:04:25.310 T:8480 warning <general>: [plugin.video.elementum] INFO bittorrent ▶ WaitForMetadata Waiting for information fetched for torrent: a6dc9a0a59ad352d66775b323fc305b1813dce0d
2024-04-05 03:04:26.323 T:8480 warning <general>: [plugin.video.elementum] INFO Init with mem size 419430400, Pieces: 6600, Piece length: 8388608
2024-04-05 03:04:26.323 T:8480 warning <general>: [plugin.video.elementum] INFO bittorrent ▶ WaitForMetadata Information fetched for torrent: a6dc9a0a59ad352d66775b323fc305b1813dce0d
2024-04-05 03:04:26.323 T:8480 warning <general>: [plugin.video.elementum] NOTI bittorrent ▶ logAlerts metadata_received_alert: Uma Familia da Pesada metadata successfully received
2024-04-05 03:04:26.323 T:8480 warning <general>: [plugin.video.elementum] INFO Using 52 buffers
2024-04-05 03:04:26.382 T:8480 warning <general>: [plugin.video.elementum] NOTI bittorrent ▶ logAlerts state_changed_alert: Uma Familia da Pesada: state changed to: finished
2024-04-05 03:04:26.382 T:8480 warning <general>: [plugin.video.elementum] NOTI bittorrent ▶ logAlerts torrent_finished_alert: Uma Familia da Pesada torrent finished downloading
2024-04-05 03:04:26.383 T:8480 warning <general>: [plugin.video.elementum] NOTI bittorrent ▶ logAlerts state_changed_alert: Uma Familia da Pesada: state changed to: checking (r)
2024-04-05 03:04:26.383 T:8480 warning <general>: [plugin.video.elementum] NOTI bittorrent ▶ logAlerts state_changed_alert: Uma Familia da Pesada: state changed to: finished
2024-04-05 03:04:26.383 T:8480 warning <general>: [plugin.video.elementum] NOTI bittorrent ▶ logAlerts torrent_finished_alert: Uma Familia da Pesada torrent finished downloading
2024-04-05 03:04:26.383 T:8480 warning <general>: [plugin.video.elementum] NOTI bittorrent ▶ logAlerts torrent_checked_alert: Uma Familia da Pesada checked
2024-04-05 03:04:26.383 T:8480 warning <general>: [plugin.video.elementum] INFO bittorrent ▶ addTorrent Downloading Uma Familia da Pesada
2024-04-05 03:04:26.383 T:8480 warning <general>: [plugin.video.elementum] INFO bittorrent ▶ GetCandidateFiles There are 222 candidate files
2024-04-05 03:04:26.389 T:2108 info <general>: Loading skin file: DialogConfirm.xml, load type: KEEP_IN_MEMORY
2024-04-05 03:04:26.417 T:8480 warning <general>: [plugin.video.elementum] INFO bittorrent ▶ playerLoop Buffer loop
2024-04-05 03:04:26.681 T:8480 warning <general>: [plugin.video.elementum] ERRO reqapi ▶ func2 Bad status getting movie with map[api_key:[29a551a65eef108dd01b46e27eb0554a] append_to_response:[credits,images,alternative_titles,translations,external_ids,trailers,release_dates] include_image_language:[pt,en,null] include_video_language:[pt,en,null] language:[pt]] on https://api.themoviedb.org/3/movie/0: 404/404 Not Found
2024-04-05 03:04:26.683 T:964 critical <general>: [plugin.video.elementum] (elementum.rpc) In Handler method ElementumRPCServer.Dialog_Select('LOCALIZE[30560];;', ['UFDP.S01.720p....)
2024-04-05 03:04:26.686 T:964 critical <general>: [plugin.video.elementum] Unhandled error: TypeError: Dialog_Select() missing 2 required positional arguments: 'autoclose' and 'preselect'
2024-04-05 03:04:26.686 T:8480 warning <general>: [plugin.video.elementum] ERRO bittorrent ▶ playerLoop Error buffering: &errors.errorString{s:"User cancelled"}
2024-04-05 03:04:26.686 T:8480 warning <general>: [plugin.video.elementum] INFO bittorrent ▶ RemoveTorrent Removing torrent: Uma Familia da Pesada
2024-04-05 03:04:26.686 T:8480 warning <general>: [plugin.video.elementum] INFO bittorrent ▶ Drop Dropping torrent: Uma Familia da Pesada
2024-04-05 03:04:26.686 T:8480 warning <general>: [plugin.video.elementum] INFO bittorrent ▶ func1 Removing the torrent without deleting files after playing ...
2024-04-05 03:04:26.686 T:8480 warning <general>: [plugin.video.elementum] NOTI bittorrent ▶ logAlerts torrent_removed_alert: Uma Familia da Pesada removed
2024-04-05 03:04:26.686 T:8480 warning <general>: [plugin.video.elementum] INFO bittorrent ▶ func1 Deleting storage type file at ...\AppData\Roaming\Kodi\cache\elementum_torrents\.a6dc9a0a59ad352d66775b323fc305b1813dce0d.memory
2024-04-05 03:04:26.686 T:8480 warning <general>: [plugin.video.elementum] INFO bittorrent ▶ func1 Removed Uma Familia da Pesada from database
—
Reply to this email directly, view it on GitHub
<#1002 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJQQCUZWBSFF6GUUKKB4XTY3Y6IDAVCNFSM6AAAAABEMS2HDCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZZGAZDGMBTGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
v20.5 Windows x64 |
There was change in Dialog_Select() for new language select functionality , iirc. |
@antonsoroko @GladistonXD I fixed that issue in the latest code. |
@GladistonXD i have not tested this but here is a new build for you to test: plugin.video.elementum-v0.1.99-43-g5e99c5d.windows_x64.zip |
I ran the tests, now everything is working perfectly. |
Expected Behavior
Display the image even if the poster link is manually specified
Current Behavior
The image link manually passed to the element does not appear during playback
Possible Solution
for the soultion:
possible to add to elementum, what @GladistonXD find here:
[link](#886 (comment))
[navigation.py](
plugin.video.elementum/resources/site-packages/elementum/navigation.py
Lines 218 to 228 in a3e1bed
after modifications in the navigation.py file, the manually added image will be displayed perfectly during playback.
the changes use 'or' so it would not affect the previous operation but could be used if someone manually added an image
Elementum 0.1.99
Windows 10: Kodi V21 Omega
Android: Kodi V21 Omega
The text was updated successfully, but these errors were encountered: