This repository has been archived by the owner on Nov 25, 2024. It is now read-only.
Disable xy if colormode is not xy #31
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Where as the HUE API produces a Light state does not product an xy value, the Group action DOES product an xy value even though the colormode says "ct" instead of "xy". |
|
What about if you want to use rgb in a group with mixed modes? There would be a manually decision needed in the ui, or not? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this addresses the suggestion from #29
I have NOT tested this patch on a group of lights yet and I'm not sure if there are any other ramifications of setting xy = null elsewhere. The StreamDeck UI seems to be ok with the changes and does what I expect, but I haven't tested it very much at this point with real lights.