Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*Suggestion* use function for defining versions #50

Open
Alexxfrolov opened this issue Jul 15, 2020 · 0 comments
Open

*Suggestion* use function for defining versions #50

Alexxfrolov opened this issue Jul 15, 2020 · 0 comments

Comments

@Alexxfrolov
Copy link
Contributor

Alexxfrolov commented Jul 15, 2020

Suggestion

Use constant or functions to generate versions (same as for acl, you can define it via @acl or via function def acl(:thumb) )

Reasoning

In some cases anyone would like not to generate full number of file versions. Right now you can skip transformations via

def transform(version, scope), do: :skip

Maybe it would be more native defining it in def versions. So you don't have to define empty transformations

Example

@versions [:original, :thumb]

or use

def versions({file, scope}) do
  [:original, :thumb]
end
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant