Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default S3 options for Uploader: signed & default_expiry_time #94

Open
rlopzc opened this issue Mar 2, 2022 · 0 comments
Open

Set default S3 options for Uploader: signed & default_expiry_time #94

rlopzc opened this issue Mar 2, 2022 · 0 comments

Comments

@rlopzc
Copy link

rlopzc commented Mar 2, 2022

This is not a bug report, more like a feature request.

It would be nice to set some default options to an uploader. i.e. signed: true, expires_in: 1 hour

defmodule Okani.Uploaders.PatientImage do
  use Waffle.Definition
  use Waffle.Ecto.Definition

  @default_signed true
  @default_expiry_time 1 * 60 * 60

Right now I'm writing a custom url function with those defaults.

I can work on it when I have time and submit a PR. Other ppl feel free to take this one :)

Thanks for your work on the lib!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant