Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut new release #6

Closed
yurrriq opened this issue Sep 9, 2016 · 14 comments
Closed

Cut new release #6

yurrriq opened this issue Sep 9, 2016 · 14 comments
Milestone

Comments

@yurrriq
Copy link
Member

yurrriq commented Sep 9, 2016

The elli-lib version has several improvements over the currently published version (1.0.5), namely wrt type naming collisions. I've merged develop into master and think it's good to go. The open issues either pertain to documentation or can wait.

@knutin, would you prefer I open a PR to knutin/elli, or should we just publish from here? Also, by we, I mean you, since you're the owner of the Hex package. 😄

@tsloughter
Copy link
Member

You may want to email him :)

Also note that he could add both or one of us to the hex package ownership if he was comfortable with that with rebar3 hex owner add elli [email protected].

@deadtrickster
Copy link
Member

Can you publish prefixed package in the meantime?

@yurrriq
Copy link
Member Author

yurrriq commented Sep 20, 2016

Sounds like @knutin will add @tsloughter and me as owners soon. Then we can cut and publish a release.

We'll want to be sure the version reflects the breaking changes. Maybe 1.2.5 isn't dramatic enough.

@tsloughter
Copy link
Member

What is the breaking change? If it is not backwards compatible it'll have to go to 2.0.0.

@yurrriq
Copy link
Member Author

yurrriq commented Sep 20, 2016

b617611...6d96cd8

@tsloughter
Copy link
Member

So the metrics callbacks changed or something? In that case then 2.0.0, if it is just removal of older OTP support than 1.2.0 is fine.

yurrriq added a commit that referenced this issue Sep 20, 2016
- Per discussion on #6, set the version to 2.0.0 to reflect the breaking
  changes w.r.t. stats collection
- Close #4 by mentioning 18.0 in README.md
- Add more badges to README.md and pull out most of the sections into
  doc/overview.edoc (close #2)
- Change "Eric Bailey" in LICENSE to "elli-lib team," since this is a
  team effort
- Add Tristan to maintainers in src/elli.app.src
@yurrriq
Copy link
Member Author

yurrriq commented Sep 20, 2016

Yeah, instead of just Timings it now returns {Timings,Sizes}. I've bumped to 2.0.0 and cleaned up the docs. I think we should be all set for 2.0.0.

@yurrriq
Copy link
Member Author

yurrriq commented Sep 20, 2016

We may want to come up with a solution for #13 first.

@deadtrickster
Copy link
Member

What about this one: #14. Travis build fails but locally it's green ¯_(ツ)_/¯

@yurrriq
Copy link
Member Author

yurrriq commented Sep 20, 2016

Haven't had a chance to look at it, that'd be good too.

@yurrriq yurrriq modified the milestone: 2.0.0 Sep 21, 2016
@yurrriq
Copy link
Member Author

yurrriq commented Sep 22, 2016

@tsloughter and I have Hex rights now. Is there anything else we wanna do before cutting 2.0.0?

@yurrriq
Copy link
Member Author

yurrriq commented Oct 17, 2016

Bump. I think we're good to go. What do y'all think?

@deadtrickster
Copy link
Member

Let's do this 👍

@yurrriq
Copy link
Member Author

yurrriq commented Oct 25, 2016

Published 2.0.0. Please test and let me know how it goes.

@yurrriq yurrriq closed this as completed Oct 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants