Refactoring and test modules

[Ealb]

Lord Brimstone has been doing some code streamlining and working to add test modules to ensure integrity - which is kinda important given how sprawling and random NG runtime behavior is, and how unlikely certain outcomes can be to arise in practice. This is a catch-all issue for general refactoring and such.

[elmokki]

That's great. I made him a collaborator to streamline things.

I will have to remark that while it would be a massive job, simply rewriting some things from scratch might be worth it. There's no real need to even consider keeping the current algorithms because they're pretty much ad hoc stuff anyway. As long as the end result makes NationGen-level of sense it's all good.

[lord-brimstone]

Thanks for the collaborator access! I might very well end up rewriting some things from scratch, but I'll have to be very careful with that because I don't want to miss something I didn't even know NationGen could do. So for now my plan was just to try to break down some of the larger classes and methods into smaller more manageable pieces so that I can unit test them. Easier said than done, I know =)

[lord-brimstone]

I've pushed a major code refactor to a new branch called "data-integrity". I don't want to push it to master until others have a chance to test out my changes and make sure I haven't royally screwed anything up. So, @Ealb , if you don't mind, would you please take my code for a test-drive?

[Ealb]

@lord-brimstone , is this issue complete, or would you consider it still open?

[lord-brimstone]

It's probably close to being complete. I think it could still use some more testing, though. My goal is to A) minimize data errors via unit tests, and B) give useful exception messages for data errors during runtime. All other errors are likely refactoring mistakes on my part (like the null pointer you messaged me about), and those need to be ironed out before I'm satisfied.