Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux/OSX runtime image support #1128

Open
2 of 4 tasks
lord-brimstone opened this issue May 10, 2020 · 1 comment
Open
2 of 4 tasks

Linux/OSX runtime image support #1128

lord-brimstone opened this issue May 10, 2020 · 1 comment

Comments

@lord-brimstone
Copy link
Collaborator

lord-brimstone commented May 10, 2020

The runtime images for Linux and OSX were never tested because we didn't have access to those platforms. This issue will cover known problems in the images. (Error text taken from Mandarbmax on the Dominions discord server)

  • Launcher shell script needs to be marked as executable

  • java needs to be marked as executable

  • fix trailing spaces on lines in launcher shell scripts

  • fix windows-style line-endings in launcher shell scripts
    /home/maxwell/Downloads/NationGen-0.7.0-RC10/NationGen: line 2: $'\r': command not found

  • Path to included java executable invalid
    /home/maxwell/Downloads/NationGen-0.7.0-RC10/NationGen: line 3: /bin/java: No such file or directory
    This is a result of the bad line endings

The nationgen jar can still be accessed normally using an appropriate version of java that is already installed:
java -jar '/home/maxwell/Downloads/NationGen-0.7.0-RC10/lib/NationGen-0.7.0-RC10.jar'

lord-brimstone added a commit to lord-brimstone/nationgen that referenced this issue May 12, 2020
* Removed trailing spaces in launch script generation
* Changed line endings in linux and osx launch scripts to LF
lord-brimstone added a commit that referenced this issue May 12, 2020
@lord-brimstone
Copy link
Collaborator Author

So, I think we can't fix the first two items on Windows, because files being marked as executable is a linux/osx thing. To confirm, I tried giving Mandarbmax the script, he marked it executable and gave it back, I downloaded and gave it right back to him, and it was no longer flagged for execution.

I think we'd need to actually be on linux or osx and then tar and gzip the files? Then maybe the flags stay? So until that's accessible or we feel comfortable with having someone else do it, I think we have to live with the end user having to manually mark the launchers and java as executable themselves. Probably should make a note about it on the release page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant