Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another JS parser? #26

Open
elsassph opened this issue Sep 26, 2017 · 4 comments
Open

Another JS parser? #26

elsassph opened this issue Sep 26, 2017 · 4 comments

Comments

@elsassph
Copy link
Owner

https://github.com/cherow/cherow
Should support import().

@elsassph
Copy link
Owner Author

elsassph commented Oct 2, 2017

Thanks, we're using acorn and it doesn't have his option.

@elsassph
Copy link
Owner Author

elsassph commented Mar 3, 2018

Still considering Cherow, but it doesn't offer some any walker algorithm so it would have to be re-implemented.

@elsassph
Copy link
Owner Author

elsassph commented Mar 4, 2018

@KFlash I applaud your dedication to making your library easier to use.

A parser delegate sound like a very useful addition for some people, but it doesn't work for me: unfortunately, I need to run the walker on nodes, after parsing.

I don't think it'll be a huge effort so don't worry - Acorn's walker will probably be very easy to adapt.

@elsassph
Copy link
Owner Author

elsassph commented Mar 5, 2018

Thanks @KFlash, estraverse look like something I could use.

I already do manual traversing up to a certain point, then I delegate to the generic walk algorithm - which could be estraverse or I'll just implement it. I hadn't looked at Acorn's implementation but I wouldn't blindly port it, just make sure I don't miss anything :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant