Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impossible value handling #90

Closed
eltonlaw opened this issue Sep 28, 2019 · 0 comments · Fixed by #91
Closed

impossible value handling #90

eltonlaw opened this issue Sep 28, 2019 · 0 comments · Fixed by #91

Comments

@eltonlaw
Copy link
Owner

eltonlaw commented Sep 28, 2019 •
edited
Loading

To fix things like negative counts and enforce range limits.

Ways of handling:

  • Return list of flagged coordinates
  • Coercion function of form
    • def coerce_value(matrix, row_index, column_index) -> value
    • def coerce_value(row, column_index) -> value (can be defined in terms of the above)
  • Throw exception

Needed as part of #68
@eltonlaw eltonlaw changed the title impossible value filter impossible value handling Sep 28, 2019
eltonlaw pushed a commit that referenced this issue Sep 29, 2019
[GH-90]clean up util folder, move to new contrib folder
85f088c 
- add to release notes
- update contrib function tests
eltonlaw pushed a commit that referenced this issue Sep 29, 2019
[GH-90] add local build recipes
5598cba
eltonlaw pushed a commit that referenced this issue Sep 29, 2019
[GH-90] release notes syntax-error
e27182a
eltonlaw pushed a commit that referenced this issue Sep 29, 2019
[GH-90] move decorators into single namespace: wrapper
663cabb
eltonlaw pushed a commit that referenced this issue Sep 29, 2019
[GH-90] move test_process unit tests to test_wrapper
2f2415a
eltonlaw pushed a commit that referenced this issue Sep 29, 2019
[GH-90] add helper function to thread functions
7ee0e50 
Will help with looking at out the middleware gets applied
eltonlaw pushed a commit that referenced this issue Sep 29, 2019
[GH-90] move utility functions into separate namespace
f6068e4
eltonlaw pushed a commit that referenced this issue Sep 29, 2019
[GH-90] init impyute.util.matrix for matrix ops
aacca91
eltonlaw pushed a commit that referenced this issue Sep 29, 2019
[GH-90] add utility to get the negative of a fn
776f523
eltonlaw pushed a commit that referenced this issue Sep 29, 2019
[GH-90] add impossible value decorator
a641373
eltonlaw pushed a commit that referenced this issue Sep 29, 2019
[GH-90] cleanup pylint artifacts
118210a
eltonlaw pushed a commit that referenced this issue Sep 29, 2019
[GH-90] rename util to ops
8faeb36
eltonlaw pushed a commit that referenced this issue Sep 29, 2019
[GH-90] fix import errors
370dd88
eltonlaw pushed a commit that referenced this issue Sep 30, 2019
[GH-90] move var arg execute into util namespace
34a3b22
eltonlaw pushed a commit that referenced this issue Sep 30, 2019
[GH-90] unit test conform output wrapper
e0fdad6
eltonlaw pushed a commit that referenced this issue Oct 5, 2019
[GH-90] - cleanup dead tests
668b3d3
eltonlaw pushed a commit that referenced this issue Oct 5, 2019
[GH-90] fast_knn pass in initial impute fn
223aa47
eltonlaw pushed a commit that referenced this issue Oct 5, 2019
[GH-90] fixup imports
1049af9 
impyute.ops.find_null->impyute.ops.matrix.nan_indices
impyute.ops.preprocess->impyute.ops.wrapper.wrappers
impyute.ops.checks->impyute.ops.wrapper.checks
impyute.ops.BadInputError -> impyute.ops.errors.BadInputError
impyute.ops.BadOutputError -> impyute.ops.errors.BadOutputError

Variable renaming:

- null_xy -> nan_xy
eltonlaw pushed a commit that referenced this issue Oct 5, 2019
[GH-90] fixup imports
e76179b 
impyute.ops.find_null->impyute.ops.matrix.nan_indices
impyute.ops.preprocess->impyute.ops.wrapper.wrappers
impyute.ops.checks->impyute.ops.wrapper.checks
impyute.ops.BadInputError -> impyute.ops.errors.BadInputError
impyute.ops.BadOutputError -> impyute.ops.errors.BadOutputError

Variable renaming:

- null_xy -> nan_xy
@eltonlaw eltonlaw mentioned this issue Oct 5, 2019
Merged
eltonlaw added a commit that referenced this issue Oct 5, 2019
@eltonlaw
Merge pull request #91 from eltonlaw/eltonlaw/90-impossible-value-han…
774ae0f 
…dling

[GH-90] impossible value handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[GH-90] impossible value handling eltonlaw/impyute
1 participant
@eltonlaw