Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

completion-in-region-mode keybindings don't override, breaking minibuffer-visible-completions #1863

Open
catern opened this issue Feb 8, 2024 · 0 comments

Comments

@catern
Copy link

catern commented Feb 8, 2024

Issue type

  • Bug report

Environment

Emacs version: Emacs 30 (trunk)
Operating System: Linux

Reproduction steps

  1. Start Emacs
  2. (evil-mode)
  3. (setq minibuffer-visible-completions t)
  4. M-tab (in normal state) to trigger completions
  5. Try using //RET to choose a completion
  6. Instead those are bound to the associate evil bindings.

Expected behavior

The //RET bindings from the minor mode should override the evil state.

Actual behavior

The minor mode bindings have no effect.

Further notes

The immediate fix, usable by a user, is:

(add-hook 'completion-in-region-mode-hook #'evil-normalize-keymaps)
(evil-make-overriding-map completion-in-region-mode-map))

Possibly there's some different way to fix it inside the evil core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant