Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More efficient access to GAP permutations #14

Open
embray opened this issue Mar 3, 2021 · 1 comment
Open

More efficient access to GAP permutations #14

embray opened this issue Mar 3, 2021 · 1 comment

Comments

@embray
Copy link
Owner

embray commented Mar 3, 2021

As mentioned at https://trac.sagemath.org/ticket/31404#comment:17 I removed efficient access to permutation elements since the libgap API currently lacks interfaces specific to permutations.

Should work on a PR to GAP to add the minimum necessary interfaces; in the meantime we can temporarily include implementations of these interfaces in gappy using the necessary internal GAP functions. Always unfortunate to have to do that, but it is doable in a pinch as GAP does not actively hide its internals.

@embray
Copy link
Owner Author

embray commented Mar 3, 2021

In Sage, permutation group elements are represented by an array of ints of size of the degree of the group. GapPermutation could include a C method for copying the elements of the GAP permutations into such an array, given a pointer to an int array and degree (basically as PermGroupElement currently does in Sage. That way the details of this could be moved into gappy (somewhat like I've done with GapInteger.to_mpz and the like).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant