Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password storage #75

Open
alaymari opened this issue Jun 22, 2021 · 4 comments
Open

Password storage #75

alaymari opened this issue Jun 22, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@alaymari
Copy link

Just as the title suggests, it would be nice if the program can store the login credentials (say in ~/.config/somedir/filerc). The command line having all the details, which can also be seen via ps is a problem.

@JayKuswahey
Copy link

JayKuswahey commented Jul 9, 2021

In principle I agree, but looking at the nature and purpose of this programme, plus the duration it takes to run, I would argue that any system you run this on and it being a security risk, you shouldn't ​be running it there?

That being said, I just edit the script with username/password, but it's very mildly annoying to have to do git stash before every pull to retain the credentials (ie. sometimes I forget), which wouldn't be any problem if we'd use a configuration file, so I support your request for a different reason.

sidenote: be sure to execute the script with 2 spaces in front, so it won't show up in your history file for others to find either.

@emericg
Copy link
Owner

emericg commented Jul 19, 2021

I think storing the credentials in a separate file wouldn't be a more secure solution than storing them in the script like right now. But I can agree that at least it would be more practical. But because the script doesn't have a config file anyway...
There might be a simple solution for those who really want to put that in a separate file anyway, I'll try to figure something out.

The right solution would be to use the OS to securely store those in a wallet, but I really don't know if that's possible in a cross plateform way, and without dependency (or possible at all).

@emericg emericg added the enhancement New feature or request label Jul 19, 2021
@Oreeeee
Copy link

Oreeeee commented May 14, 2022

#90

@fidodido48
Copy link

Just use OS env vars?
Linux uses $HOME/.env file by default for user secrets, so no reason to reinvent the wheel.

As for Windows (i dont use it), maybe this help a bit:
https://stackoverflow.com/questions/48607302/using-env-files-to-set-environment-variables-in-windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants