Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

image loader for file:// is blocking, while image loader for http:// runs fine. #5375

Open
hacknus opened this issue Nov 15, 2024 · 1 comment · May be fixed by #5394 or #4069
Open

image loader for file:// is blocking, while image loader for http:// runs fine. #5375

hacknus opened this issue Nov 15, 2024 · 1 comment · May be fixed by #5394 or #4069
Labels
bug Something is broken egui

Comments

@hacknus
Copy link
Contributor

hacknus commented Nov 15, 2024

Describe the bug
When using

ui.image("file://image.png");

it is blocking until the image is loaded.

But

ui.image("https://web.site.com/image.png");

will run fine and updates the GUI while the image is loading.

Expected behavior
All loaders should be non-blocking.

Desktop (please complete the following information):

  • OS: macOS 14.6.1
  • Version: egui 0.29
@hacknus hacknus added the bug Something is broken label Nov 15, 2024
@hacknus hacknus mentioned this issue Nov 15, 2024
Open
@lucasmerlin
Copy link
Collaborator

This should definitely be improved, I think it would be fine to just spawn a thread to load and decode the image?
Seems like someone already opened a PR: #4069
But it's stale and needs some more work before it's ready.

@lucasmerlin lucasmerlin linked a pull request Nov 16, 2024 that will close this issue
Draft
@bircni bircni linked a pull request Nov 20, 2024 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something is broken egui
Projects
None yet
Milestone
No milestone
2 participants
@lucasmerlin @hacknus