Skip to content
This repository has been archived by the owner on Aug 27, 2024. It is now read-only.

[Feature]: Fibonacci examples should take the number indexes as command-line arguments #23

Open
1 task done
rvolosatovs opened this issue Jul 28, 2022 · 4 comments
Open
1 task done
Assignees
Labels
enhancement New feature or request

Comments

@rvolosatovs
Copy link
Member

rvolosatovs commented Jul 28, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Description

Fibonacci examples should take the number indexes as command-line arguments.

All examples except Zig should be updated.
See #18

Note, that currently Enarx incorrectly handles argv enarx/enarx#2090.
Test this with wasmtime until that's done

Acceptance Criteria

No response

Suggestions for a technical implementation

No response

@rvolosatovs
Copy link
Member Author

rvolosatovs commented Jul 28, 2022

Assignment:

@rvolosatovs
Copy link
Member Author

@MaxGraey would you be interested in adapting the AssemblyScript example?
(for each index passed on command-line it should print the fibonacci sequence number corresponding to that index, see Zig example)

@rvolosatovs
Copy link
Member Author

rvolosatovs commented Jul 28, 2022

A better approach could be to take argument from stdin when no arguments are specified

@rvolosatovs
Copy link
Member Author

Please use:

./tests/run.sh ./tests/fibonacci/golden/default --wasmcfgfile ./result/Enarx.toml ./result/main.wasm
cat ./tests/fibonacci/stdin | ./tests/run.sh ./tests/fibonacci/golden/stdin ./result/main.wasm

For testing, where result is a directory containing Enarx.toml and main.wasm

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
Status: New
Development

No branches or pull requests

5 participants