Fix codefactor warnings and add it to readme

README.md

@@ -4,6 +4,7 @@
 [![GoDoc](https://img.shields.io/badge/godoc-reference-5272B4)](https://godoc.org/github.com/enbility/eebus-go)
 [![Coverage Status](https://coveralls.io/repos/github/enbility/eebus-go/badge.svg?branch=dev)](https://coveralls.io/github/enbility/eebus-go?branch=dev)
 [![Go report](https://goreportcard.com/badge/github.com/enbility/eebus-go)](https://goreportcard.com/report/github.com/enbility/eebus-go)
+[![CodeFactor](https://www.codefactor.io/repository/github/enbility/eebus-go/badge)](https://www.codefactor.io/repository/github/enbility/eebus-go)
 
 This library provides a foundation for implementing [EEBUS](https://eebus.org) use cases in [go](https://golang.org). It uses the SHIP implementation [ship-go](https://github.com/enbility/ship-go) and the SPINE implementation [spine-go](https://github.com/enbility/spine-go). Both repositories started as part of this repository, before they were moved into their own separate repositories and go packages.
 

api/configuration.go

@@ -109,34 +109,34 @@ func NewConfiguration(
 
 	if len(vendorCode) == 0 {
 		return nil, fmt.Errorf("vendorCode %s", isRequired)
-	} else {
-		configuration.vendorCode = vendorCode
 	}
+	configuration.vendorCode = vendorCode
+
 	if len(deviceBrand) == 0 {
 		return nil, fmt.Errorf("brand %s", isRequired)
-	} else {
-		configuration.deviceBrand = deviceBrand
 	}
+	configuration.deviceBrand = deviceBrand
+
 	if len(deviceModel) == 0 {
 		return nil, fmt.Errorf("model %s", isRequired)
-	} else {
-		configuration.deviceModel = deviceModel
 	}
+	configuration.deviceModel = deviceModel
+
 	if len(serialNumber) == 0 {
 		return nil, fmt.Errorf("serialNumber %s", isRequired)
-	} else {
-		configuration.deviceSerialNumber = serialNumber
 	}
+	configuration.deviceSerialNumber = serialNumber
+
 	if len(deviceType) == 0 {
 		return nil, fmt.Errorf("deviceType %s", isRequired)
-	} else {
-		configuration.deviceType = deviceType
 	}
+	configuration.deviceType = deviceType
+
 	if len(entityTypes) == 0 {
 		return nil, fmt.Errorf("entityTypes %s", isRequired)
-	} else {
-		configuration.entityTypes = entityTypes
 	}
+	configuration.entityTypes = entityTypes
+
 	// set default
 	configuration.featureSet = model.NetworkManagementFeatureSetTypeSmart
 

features/timeseries.go

@@ -146,6 +146,9 @@ func (t *TimeSeries) GetDescriptionForType(timeSeriesType model.TimeSeriesTypeTy
 // return current constraints for Time Series
 func (t *TimeSeries) GetConstraints() ([]model.TimeSeriesConstraintsDataType, error) {
 	rData := t.featureRemote.DataCopy(model.FunctionTypeTimeSeriesConstraintsListData)
+
+	// the codefactor warning is invalid, as .(type) check can not be replaced with if then
+	//revive:disable-next-line
 	switch constraintsData := rData.(type) {
 	case *model.TimeSeriesConstraintsListDataType:
 		if constraintsData == nil {