Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

it should not be allowed to submit more attestations than vote-1 #279

Open
brenzi opened this issue Nov 10, 2022 · 2 comments
Open

it should not be allowed to submit more attestations than vote-1 #279

brenzi opened this issue Nov 10, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@brenzi
Copy link
Member

brenzi commented Nov 10, 2022

Currently, meetup validation is too tolerant. Even if this is not strictly critical in terms of attacks, it made an e2e test pass that should've failed which led to trouble in production (#278 caused by encointer/encointer-wallet-flutter#866)

two options:

  1. prevent submission of too many attestations directly upon submission
  2. exclude attesters that submit too many attestation upon meetup validation

I strongly favor option 1) because this will allow to fix an error while it is still possible (while a gathering is still ongoing)

@pifragile
Copy link
Contributor

Not happy about the label bug, it is a missing feature at most :)
Option 1 also makes more sense to me. It would be an input validation of the data. But honestly I am not sure about it, because it seems that this feature would only be here to catch errors made by the app code, and not sure if it is the job of the runtime to catch those.

@brenzi
Copy link
Member Author

brenzi commented Nov 14, 2022

I think input validation is good practise, runtime or not. Avoiding hard to debug situations can save us a lot of work

@brenzi brenzi added enhancement New feature or request and removed bug Something isn't working labels Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants