Fixes: Fix not close trace file when the sim is finished #2120
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During my testing of LiteX simulations using Verilator, I discovered that when the BIOS executes the
finish
command to properly terminate the simulation, the FST files were not being closed correctly. This resulted insim.fst
andsim.fst.hier
not being merged properly.Changes
finish
command is executed.Testing
finish
command, the FST files close correctly and the waveform files merge as expected.Additional Information
Thank you to the authors for designing such an excellent project with LiteX! I hope this fix can be accepted upstream.