Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: Fix not close trace file when the sim is finished #2120

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

juiceRv
Copy link

@juiceRv juiceRv commented Nov 7, 2024

Description

During my testing of LiteX simulations using Verilator, I discovered that when the BIOS executes the finish command to properly terminate the simulation, the FST files were not being closed correctly. This resulted in sim.fst and sim.fst.hier not being merged properly.

Changes

  • Fixed the logic to ensure FST files are correctly closed when the finish command is executed.

Testing

  • Verified that after executing the finish command, the FST files close correctly and the waveform files merge as expected.

Additional Information

Thank you to the authors for designing such an excellent project with LiteX! I hope this fix can be accepted upstream.

@juiceRv juiceRv changed the title fFixes: Fix no close trace file when the sim is finished Fixes: Fix no close trace file when the sim is finished Nov 7, 2024
@juiceRv
Copy link
Author

juiceRv commented Nov 7, 2024

litex_sim --cpu-type=picorv32 --sim-debug --gtkwave-savefile --trace --trace-fst --with-sdram --sdram-module MT48LC16M16 --sdram-data-width 32 --soc-csv csr.csv

Once the simulation is running, execute the following trace commands:

trace
sdram_init
trace
finish

@juiceRv juiceRv changed the title Fixes: Fix no close trace file when the sim is finished Fixes: Fix not close trace file when the sim is finished Nov 11, 2024
@enjoy-digital enjoy-digital merged commit f056f37 into enjoy-digital:master Nov 12, 2024
@enjoy-digital
Copy link
Owner

Thanks @juiceRv!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants